Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAT confirmations are initialized on clean profile #10085

Closed
btlechowski opened this issue Jun 4, 2020 · 4 comments
Closed

BAT confirmations are initialized on clean profile #10085

btlechowski opened this issue Jun 4, 2020 · 4 comments

Comments

@btlechowski
Copy link

btlechowski commented Jun 4, 2020

Follow up to #9544

Steps to Reproduce

  1. Clean profile
  2. Run Brave with:
    In 1.10.x use --enable-logging=stderr --vmodule=brave_ads=3
    in 1.11.x use --enable-logging=stderr --vmodule="*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/bat-native-ledger/*"=6
  3. Check the log for Initializing confirmations
  4. Check if file Default/rewards_service/confirmations.json is created

Actual result:

Initializing confirmations is recorded in the logs
Default/rewards_service/confirmations.json is created

Expected result:

Initializing confirmations is not recorded in the logs
Default/rewards_service/confirmations.json is not created

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.10.82 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @tmancey

@tmancey
Copy link
Contributor

tmancey commented Jun 4, 2020

Fixed in 1.11.x

@bsclifton
Copy link
Member

@tmancey can we close this issue?

@btlechowski
Copy link
Author

Also reproduced on upgrade

Brave 1.10.87 Chromium: 83.0.4103.61 (Official Build) (64-bit)
Revision 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS Ubuntu 18.04 LTS

Failed on upgrade from 1.9.x - rewards never enabled in 1.9.x
Failed on upgrade from 0.61.x - rewards never enabled in 0.61.x
Used https://github.com/brave/brave-browser/releases/tag/v0.61.52

@LaurenWags
Copy link
Member

LaurenWags commented Jun 26, 2020

Verified passed with

Brave | 1.11.78 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
-- | --
Revision | 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Verified STR from description. Confirmed Initializing confirmations is not recorded in the logs. Confirmed Default/rewards_service/confirmations.json is not created.
  • Reproduced issue on 1.10.97 with Rewards never enabled. Upgraded to 1.11.x. Confirmed Initializing confirmations is not recorded in the logs. However, since Default/rewards_service/confirmations.json was created with 1.10.97, it does still exist.

Verification passed on


Brave | 1.11.78 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
-- | --
Revision | 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS | Windows 10 OS Version 1903 (Build 18362.900)


  • Verified the STR from the description

Clean profile:

  • Verified that Initializing confirmations logs are not recorded when brave is launched.
  • Verified that confirmations.json file isn't created under Default/rewards_service/

Upgraded profile:

  • Launched 1.10.97 and verified that Initializing confirmations logs are recorded and then upgrade the profile to 1.11.78 and ensured that Initializing confirmations logs are not recorded. confirmations.json file is present under Default/rewards_service/ as it was created with 1.10.97

Verified passed with

Brave	1.11.84 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision	8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS	Linux
  • Verified STR from description. Confirmed Initializing confirmations is not recorded in the logs. Confirmed Default/rewards_service/confirmations.json is not created.
  • Reproduced issue on 1.10.97 with Rewards never enabled. Upgraded to 1.11.x. Confirmed Initializing confirmations is not recorded in the logs. However, since Default/rewards_service/confirmations.json was created with 1.10.97, it does still exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants