Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Customized Dashboard settings tool tip is shown outside the modal popup #10299

Closed
GeetaSarvadnya opened this issue Jun 16, 2020 · 2 comments · Fixed by brave/brave-core#6767

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 16, 2020

Description

Found while testing #9455
Customized Dashboard settings tool tip is shown outside the modal popup

Steps to Reproduce

  1. Clean profile 1.11.x
  2. Open a NTP and click on Customized Dashboard settings
  3. Mouse hover outside the Customized Dashboard settings modal popup
  4. Customized Dashboard settings tool tip is shown outside the modal popup

Note: when modal popup is open, mouse over on the bottom right corner icons (Bookmarks, Preferences and History) also shows Customized Dashboard settings tool tip

Actual result:

Customized Dashboard settings tool tip is shown outside the modal popup
image

image

image

Expected result:

Customized Dashboard settings tool tip should not be shown outside the modal popup

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.11.65 Chromium: 83.0.4103.97 (Official Build) dev (64-bit)
Revision 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS Windows 10 OS Version 1903 (Build 18362.30)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @rebron @karenkliu

@rebron
Copy link
Collaborator

rebron commented Aug 7, 2020

cc: @ryanml Note priority though.

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Oct 21, 2020

Verification passed on


Brave | 1.17.42 Chromium: 86.0.4240.99 (Official Build) nightly (64-bit)
-- | --
Revision | 002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS | Windows 10 OS Version 1903 (Build 18362.1082)


  • Verified the STR from the description

image

  • Verified on both clean and upgraded profiles

Verification passed on

Brave 1.17.43 Chromium: 86.0.4240.99 (Official Build) nightly (64-bit)
Revision 002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS Ubuntu 18.04 LTS
  • Verified the STR from the description
    image

  • Verified on both clean and upgraded profiles


Verified passed with

Brave | 1.17.45 Chromium: 86.0.4240.99 (Official Build) dev (x86_64)
-- | --
Revision | 002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Verified STR from description

Screen Shot 2020-10-21 at 1 43 30 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment