[Desktop] Huge ads priority in logs when priority is set to zero

[btlechowski]

Found when testing #5232

Steps to Reproduce

1. Load staging catalog ads_priority_0.txt
2. Try to show the ad

Actual result:

The log shows

[6614:6614:0710/202200.229131:VERBOSE2:ads_impl.cc(992)] 0 eligible ads with a priority of 1264684032

Expected result:

TBD

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave	1.11.92 Chromium: 84.0.4147.68 (Official Build) dev (64-bit)
Revision	e7b7234037639b407e69c5428c891ce018cd6c0d-refs/branch-heads/4147@{#772}
OS	Ubuntu 18.04 LTS

cc @brave/legacy_qa @tmancey

[tmancey]

@btlechowski Valid values are 1 to 10 in the catalog, however as a defence I added 0 to never show the ad. This is fixed in 1.13.x and will not cause any side effects in older versions (other than display issues in the log.

[btlechowski]

Thanks @tmancey. Closing as it is fixed in nightly.

[LaurenWags]

Verified passed with

Brave | 1.13.79 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
-- | --
Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | macOS Version 10.14.6 (Build 18G3020)

• Verified STR in description, used this catalog - zero-priority-catalog.txt

• Confirmed I did not see 0 eligible ads with a priority of 1264684032 in the logs, instead I saw [1797:775:0824/135413.425645:VERBOSE1:ads_impl.cc(1047)] Ad notification not shown: No eligible ads found which is accurate based on the catalog used.

---

Verification passed on

Brave | 1.13.79 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
-- | --
Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

• Verified the STR from the description used catalog mentioned above
• Verified that ads are not shown when the Priority is set to zero in catalog

[20980:20868:0825/171526.821:VERBOSE1:ads_impl.cc(1047)] Ad notification not shown: No eligible ads found

• Verified that ads are triggered when the priority is set to 1 in catalog

[6860:20552:0825/170016.347:VERBOSE1:ads_impl.cc(928)] No eligible ads found in categories:
[6860:20552:0825/170016.347:VERBOSE1:ads_impl.cc(930)]   technology & computing
[6860:20552:0825/170016.347:VERBOSE1:ads_impl.cc(930)]   personal finance
[6860:20552:0825/170016.347:VERBOSE1:ads_impl.cc(930)]   food & drink
[6860:20552:0825/170016.347:VERBOSE1:ads_impl.cc(976)] Serving ad notification from untargeted category
[6860:20552:0825/170016.348:VERBOSE2:eligible_ads_priority_filter.cc(81)] 1 eligible ads with a priority of 1
[6860:20552:0825/170016.348:VERBOSE1:ads_impl.cc(1014)] Found 1 eligible ads
[6860:20552:0825/170016.348:VERBOSE3:client.cc(525)] Saving client state
[6860:20552:0825/170016.348:VERBOSE3:client.cc(525)] Saving client state
[6860:20552:0825/170016.348:VERBOSE3:client.cc(525)] Saving client state
[6860:20552:0825/170016.348:VERBOSE3:client.cc(525)] Saving client state
[6860:20552:0825/170016.348:VERBOSE1:ads_impl.cc(1277)] Ad notification shown:
  uuid: 2931ec60-effb-410e-bee5-ea0d8bf857e3
  parentUuid: 98c92e38-bc71-4bea-af87-211f0215c498
  creativeInstanceId: 6a66e391-9a1d-4349-8a04-64751edf692b
  creativeSetId: 0aa3505d-9829-4c34-911a-7e0ecb691483
  category: untargeted
  title: Brave.com
  body: Brave.com
  targetUrl: https://brave.com

[6860:20552:0825/170016.349:VERBOSE1:confirmations_impl.cc(1163)] Confirm ad:
  creativeInstanceId: 6a66e391-9a1d-4349-8a04-64751edf692b
  creativeSetId: 0aa3505d-9829-4c34-911a-7e0ecb691483
  category: untargeted
  targetUrl: https://brave.com
  geoTarget: US
  confirmationType: view

---

Verification passed on

Brave	1.13.79 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
Revision	4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS	Ubuntu 18.04 LTS

Verified ads with priority 0 will not be shown:

[16246:16246:0825/182541.126569:VERBOSE1:ads_impl.cc(1047)] Ad notification not shown: No eligible ads found

Catalog used: ads_priority_0_v3.txt

Verified that ads with priority > 0 are shown and ads with priority = 0 are not shown
Catalog used: ads_priority_mix_v3.txt