Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] LICENSE and LICENSES.chromium.html files missing from latest stable release (1.11.97) #10772

Closed
mixedCase opened this issue Jul 16, 2020 · 3 comments · Fixed by brave/brave-core#6170

Comments

@mixedCase
Copy link

Description

Files LICENSE and LICENSES.chromium.html are missing from latest stable release (1.11.97)

Steps to Reproduce

  1. Download 1.11.97 release .zip for Linux
  2. Open it and take a look at the file list

Actual result:

No LICENSE nor LICENSES.chromium.html files, like there were in 1.10.97

Expected result:

LICENSE nor LICENSES.chromium.html files, like there were in 1.10.97

Reproduces how often:

Every time

Brave version (brave://version info)

1.11.97

Rest of issue template is irrelevant.

@mixedCase mixedCase changed the title [Desktop] LICENSE and LICENSES files missing from latest stable release (1.11.97) [Desktop] LICENSE and LICENSES.chromium.html files missing from latest stable release (1.11.97) Jul 16, 2020
@bsclifton
Copy link
Member

cc: @fmarier

@fmarier
Copy link
Member

fmarier commented Jul 20, 2020

That's a direct result of brave/brave-core#5562. Now we know why that code was there.

The licensing info is available (and up-to-date) on these pages:

  • brave://settings/help
  • brave://credits

but we should at least include a copy of the MPL in the root of the zip/tarball.

@fmarier fmarier self-assigned this Jul 20, 2020
fmarier added a commit to brave/brave-core that referenced this issue Jul 22, 2020
@fmarier fmarier added this to the 1.13.x - Nightly milestone Jul 22, 2020
@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop labels Aug 7, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Aug 19, 2020

Verified passed with

Brave | 1.13.77 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
-- | --
Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | macOS Version 10.14.6 (Build 18G3020)

10772


Verification passed on

Brave | 1.13.77 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
-- | --
Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | Windows 10 OS Version 1903 (Build 18362.1016)


Verification passed on

Brave 1.13.79 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
Revision 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS Ubuntu 18.04 LTS

@fmarier fmarier removed the OS/Android Fixes related to Android browser functionality label Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment