Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom style cosmetic filter rules for class selectors not applied #10862

Closed
antonok-edm opened this issue Jul 22, 2020 · 2 comments · Fixed by brave/brave-core#6176
Closed

Comments

@antonok-edm
Copy link
Collaborator

Originally posted by @Yuki2718 in #8478 (comment)

Applying google.*##.mn-dwn-arw:style(top: 27px !important;) to Google search results in move of arrow icons as on uBO - for this screenshot I disabled uBO's other filters but keeping them enabled didn't change the results, only changed other appearance such that URL was shown in grey the same as the last screenshot below.

google1

But the same rule on Brave Nightly 1.8.22 didn't and changing the wildcard to "com" google.com##.mn-dwn-arw:style(top: 27px !important;) didn't make a difference.

brave

google2

Any rules without class selectors work fine. For example, brave.com##*:style(background: #f00 !important) changes everything on brave.com to appear with a red background.

@LaurenWags
Copy link
Member

LaurenWags commented Aug 19, 2020

Verified passed with

Brave | 1.13.77 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
-- | --
Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-08-19 at 11 45 33 AM

Screen Shot 2020-08-19 at 11 44 47 AM

  • Note, if you scroll down the page it resumes normal background. Confirmed with @antonok-edm this is ok.

Verification passed on

Brave | 1.13.77 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
-- | --
Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | Windows 10 OS Version 1903 (Build 18362.1016)


Verification passed on

Brave 1.13.79 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
Revision 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS Ubuntu 18.04 LTS

image

@srirambv
Copy link
Contributor

Removing Android label as this is desktop only. @antonok-edm confirmed it

@srirambv srirambv removed the OS/Android Fixes related to Android browser functionality label Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment