Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sell panel should include to the total amount to be received in USD (Gemini) #11046

Closed
ryanml opened this issue Aug 1, 2020 · 2 comments · Fixed by brave/brave-core#6307
Closed

Sell panel should include to the total amount to be received in USD (Gemini) #11046

ryanml opened this issue Aug 1, 2020 · 2 comments · Fixed by brave/brave-core#6307
Assignees
@ryanml
Labels
feature/widgets OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.13.x - Release #1

Comments

@ryanml
Copy link
Contributor

ryanml commented Aug 1, 2020

Currently, the total label in the sell screen just shows the total amount of crypto to be sold. It should display the total amount of USD to be received, which is calculated by working out (quantity * price) - fee.

Screen Shot 2020-07-31 at 6 07 53 PM
Screen Shot 2020-07-31 at 5 47 53 PM

In addition, the label on the Buy screen should read as Total Spent, and on Sell, Total Received
@ryanml ryanml added this to the 1.14.x - Nightly milestone Aug 1, 2020
@ryanml ryanml self-assigned this Aug 1, 2020
@ryanml ryanml mentioned this issue Aug 1, 2020
Merged
32 tasks
ryanml added a commit to brave/brave-core that referenced this issue Aug 3, 2020
@ryanml
Fixes brave/brave-browser#11046 - Shows ttotal amount to be received …
4856c98 
…in a Gemini sale
@ryanml ryanml modified the milestones: 1.14.x - Nightly, 1.13.x - Beta Aug 4, 2020
@ryanml ryanml mentioned this issue Aug 4, 2020
Merged
4 tasks
This was referenced Aug 21, 2020
Closed
Closed
Closed
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.14.61 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
Revision 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS Windows 10 OS Version 1809 (Build 17763.1397)
  • Verified total conversion value is shown in the trade window for both sell and buy
Sell Buy
image image

Verification passed on

Brave 1.14.61 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
Revision 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS Linux
  • Verified total conversion value is shown in the trade window for both sell and buy
Sell Buy
image image

Verification passed on

Brave 1.14.61 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
Revision 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS macOS Version 10.15.5 (Build 19F101)
  • Verified total conversion value is shown in the trade window for both sell and buy
Sell Buy
image image

@LaurenWags LaurenWags mentioned this issue Aug 26, 2020
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Aug 26, 2020 •
edited
Loading

changing to release-notes/exclude per discussion with @rebron

@rebron rebron mentioned this issue Aug 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
feature/widgets OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.13.x - Release #1
Development

Successfully merging a pull request may close this issue.

Shows total amount to be received in a Gemini sell order brave/brave-core
3 participants
@ryanml @srirambv @LaurenWags