[Desktop] Claim doesn't work for existing wallets

[NejcZdovc]

Description

When you are connecting already used KYC wallet to claim it will return 200 compared to 201 for new wallets. We need to handled 200 response as well.

Steps to Reproduce

1. Enable rewards
2. Connect old KYC wallet that was already connected

Actual result:

Claim fails

Expected result:

Claim should work

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release?
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

[LaurenWags]

Uplift approved, waiting on new 1.13.x build to test.

[GeetaSarvadnya]

Verification passed on

Brave | 1.13.80 Chromium: 85.0.4183.83 (Official Build) (64-bit)
-- | --
Revision | 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

• Verified test plan from Fixes claim for existing wallets brave-core#6384 and Removes anonymous address from external wallet flow brave-core#6401

• Verified STR from the description

• Clean profile, enabled rewards claimed ag grants and wallet status is Not connected and Balance info is displayed as expected in brave://rewards-internals
  
  
  

• Connected KYC'd Uphold wallet. Confirmed seeing the below in my logs:

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/redacted/claim
> Method: UrlMethod::POST
> Content: ...

[ RESPONSE - OnTransferFunds ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/redacted/claim
> Result: Success
> HTTP Code: 200

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Method: UrlMethod::POST
> Content:

[ RESPONSE - OnRedeemTokens ]
> Url: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Result: Success
> HTTP Code: 200

• Verified Ad grants are moved to uphold card and wallet status is displayed as Verified in brave://rewards-internals
  
  
  
• Verified one-time tips are processed successfully
• Verified recurring tips are processed successfully
• Verified AC is processed successfully

---

Verification PASSED on macOS 10.15.6 x64 using the following builds:

Brave | 1.13.80 Chromium: 85.0.4183.83 (Official Build) (64-bit)
-- | --
Revision | 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS | macOS Version 10.15.6 (Build 19G73)

Went through the STR/Cases outlined via brave/brave-core#6384 and brave/brave-core#6401.

Before Connecting Uphold	Before Connecting Uphold

Connected to a KYC staging account and ensured the following logs appeared without any issues:

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/[..............]/claim
> Method: UrlMethod::POST
> Content....

[ RESPONSE - OnTransferFunds ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/[..............]/claim
> Result: Success
> HTTP Code: 200

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Method: UrlMethod::POST
> Content...

[ RESPONSE - OnRedeemTokens ]
> Url: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Result: Success
> HTTP Code: 200

Once claimed, ensured that brave://rewards and brave://rewards-internals displayed the correct information:

After Connecting Uphold	After Connecting Uphold

Ensured that it also appeared correctly in Uphold as per the following:

Ensured that you can do the following:

• Tip verified publishers
• ensured that a-c is being processed
• ensured that recurring tips are being processed during a-c

---

Verification passed on

Brave	1.13.80 Chromium: 85.0.4183.83 (Official Build) (64-bit)
Revision	94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS	Ubuntu 18.04 LTS

Verified STR outlined via brave/brave-core#6384 and brave/brave-core#6401.

Before connecting to uphold

Connected to a KYC staging account and ensured the following logs appeared without any issues:

[ RESPONSE - OnTransferFunds ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/[redacted]/claim
> Result: Success
> HTTP Code: 200
> Body: null

[ RESPONSE - OnRedeemTokens ]
> Url: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Result: Success
> HTTP Code: 200

Once claimed, ensured that brave://rewards and brave://rewards-internals displayed the correct information: