Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop][CW] Backup seed words message should not block token list #11330

Closed
srirambv opened this issue Aug 19, 2020 · 2 comments · Fixed by brave/ethereum-remote-client#165
Closed

Comments

@srirambv
Copy link
Contributor

Description

Backup seed words message should not block token list

Steps to Reproduce

  1. Load 0.1.66 component
  2. Skip wallet back up process
  3. Add a bunch of tokens
  4. Scroll down, backup token message is blocking send token button

Actual result:

image

Expected result:

Should not have a fixed position but rather a relative position at the end of the page with scroll

Reproduces how often:

Easy.

Brave version (brave://version info)

Brave 1.13.75 Chromium: 85.0.4183.69 (Official Build) beta (64-bit)
Revision 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS Linux
Component 0.1.66

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? NA

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

This is an issue on MM as well. Would be a good upstream fix as polish/enhancement

@srirambv srirambv added suggestion polish Nice to have — usually related to front-end/visual tasks QA/Yes release-notes/exclude OS/Desktop labels Aug 19, 2020
@srirambv
Copy link
Contributor Author

Moving out of 1.0.21 as this is just a suggestion and should not block the release

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.13.86 Chromium: 85.0.4183.102 (Official Build) (64-bit)
Revision ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS Windows 10 OS Version 1809 (Build 17763.1457)
Component 0.1.75
  • Verified backup seed words message is not blocking add token list
    image

Verification passed on

Brave 1.15.46 Chromium: 85.0.4183.102 (Official Build) beta (64-bit)
Revision ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS Linux
Component 0.1.75
  • Verified backup seed words message is not blocking add token list
    image

Verification passed on

Brave 1.16.7 Chromium: 85.0.4183.102 (Official Build) nightly (64-bit)
Revision ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS macOS Version 10.15.5 (Build 19F101)
Component 0.1.75
  • Verified backup seed words message is not blocking add token list
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant