Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop][CW] Memo field is missing in edit account window #11355

Closed
srirambv opened this issue Aug 21, 2020 · 2 comments
Closed

[Desktop][CW] Memo field is missing in edit account window #11355

srirambv opened this issue Aug 21, 2020 · 2 comments

Comments

@srirambv
Copy link
Contributor

Description

Memo field is missing in edit account window

Steps to Reproduce

  1. Settings -> Contacts -> Account
  2. Account shows a memo in view mode
  3. Go to edit mode, no text field for memo is shown

Actual result:

image

Expected result:

Should contain a memo field

Reproduces how often:

Easy

Brave version (brave://version info)

ave 1.13.78 Chromium: 85.0.4183.69 (Official Build) beta (64-bit)
Revision 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS Linux
Component 1.0.20

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? NA

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

Issue happens on current released component as well. Found while verifying #10999
Setting issue to 1.0.22 release as this is an existing issue and not a release blocker

ryanml added a commit to brave/ethereum-remote-client that referenced this issue Aug 21, 2020
ryanml added a commit to brave/ethereum-remote-client that referenced this issue Aug 23, 2020
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.12.114 Chromium: 84.0.4147.135 (Official Build) (64-bit)
Revision c42bd09b3f24da1698d71d3b4f57402137163566-refs/branch-heads/4147@{#1102}
OS Windows 10 OS Version 1809 (Build 17763.1397)
Component 0.1.72
  • Verified memo field is shown in edit mode.
    image
  • Verified added memo is shown in view mode
    image

Verification passed on

Brave 1.13.78 Chromium: 85.0.4183.69 (Official Build) beta (64-bit)
Revision 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS Linux
Component 0.1.72
  • Verified memo field is shown in edit mode.
    image
  • Verified added memo is shown in view mode
    image

Verification passed on

Brave 1.15.4 Chromium: 85.0.4183.78 (Official Build) nightly (64-bit)
Revision 720ec01a54ea94d2d8b7a1d273e0fa89722fb11b-refs/branch-heads/4183@{#1603}
OS macOS Version 10.15.5 (Build 19F101)
Component 0.1.72
  • Verified memo field is shown in edit mode.
    image
  • Verified added memo is shown in view mode
    image

@srirambv
Copy link
Contributor Author

Closed by brave/ethereum-remote-client@b6a9d98

@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant