Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave Ads fail to migrate confirmations.json if upgrading from builds prior to 1.12.2 if ads were switched off #12260

Closed
tmancey opened this issue Oct 21, 2020 · 1 comment · Fixed by brave/brave-core#6917
Closed

Brave Ads fail to migrate confirmations.json if upgrading from builds prior to 1.12.2 if ads were switched off #12260

tmancey opened this issue Oct 21, 2020 · 1 comment · Fixed by brave/brave-core#6917
Assignees
@tmancey
Labels
bug feature/ads OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.17.x - Release #1

Comments

@tmancey
Copy link
Contributor

tmancey commented Oct 21, 2020 •
edited
Loading

Description

Steps to Reproduce

  1. Install 1.14.19 or older
  2. Join Rewards
  3. Disable Brave Ads
  4. Upgrade to 1.18.5 or above
  5. Enable Brave Ads

Actual result:

Brave Ads should successfully initialize and show ads

Expected result:

Brave Ads fails to initialize due to the migration path and does not show ads. Toggling ads on/off does not resolve the issue. There is no workaround. However, once the user upgrades to a version with this fix their confirmations will be migrated.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:
@tmancey tmancey self-assigned this Oct 21, 2020
@tmancey tmancey added release-notes/include QA/Yes priority/P2 A bad problem. We might uplift this to the next planned release. priority/P1 A very extremely bad problem. We might push a hotfix for it. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Oct 21, 2020
This was referenced Oct 21, 2020
Merged
Merged
Closed
@tmancey tmancey added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Oct 21, 2020
@tmancey tmancey changed the title Brave Ads fail to migrate confirmations.json if upgrading from builds prior to 1.14.20 if ads were switched off Brave Ads fail to migrate confirmations.json if upgrading from builds prior to 1.12.2 if ads were switched off Oct 21, 2020
@tmancey tmancey added this to the 1.18.x - Nightly milestone Oct 22, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Nov 13, 2020 •
edited by btlechowski
Loading

Verified passed with

Brave	1.17.68 Chromium: 87.0.4280.49 (Official Build) (x86_64)
Revision	f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS	macOS Version 10.14.6 (Build 18G6042)

Verified STR from #12260 (comment)

Confirmed re-enabling ads from 2 ways:

1. Re-enable Ads via brave://rewards page

Installed 1.14.19, enabled Rewards. Disabled Ads via brave://rewards.
Closed Brave and renamed profile to Brave-Browser.
Launched with 1.17.x build above and enabled Ads via brave://rewards page.
Confirmed ads were being initialized per the following:

[1818:775:1113/075749.879702:VERBOSE1:ads_impl.cc(136)] Initializing ads
[1818:775:1113/075749.934268:VERBOSE1:page_classifier.cc(151)] Successfully loaded emgmepnebbddgnkhfmhdhmjifkglkamo page classification user model
[1818:775:1113/075750.221898:VERBOSE1:page_classifier.cc(160)] Successfully initialized emgmepnebbddgnkhfmhdhmjifkglkamo page classification user model
[1818:775:1113/075750.223964:VERBOSE1:purchase_intent_classifier.cc(340)] Successfully loaded kkjipiepeooghlclkedllogndmohhnhi purchase intent user model
[1818:775:1113/075750.225030:VERBOSE1:purchase_intent_classifier.cc(56)] Parsed purchase intent user model version 1 with a signal level of 1, classification threshold of 3 and a signal decay time window of 604800 seconds
[1818:775:1113/075750.225081:VERBOSE1:purchase_intent_classifier.cc(348)] Successfully initialized kkjipiepeooghlclkedllogndmohhnhi purchase intent user model
[1818:775:1113/075750.225117:VERBOSE1:database_migration.cc(51)] Migrated database from version 1 to version 3
[1818:775:1113/075750.233889:VERBOSE3:client.cc(600)] Loading client state
[1818:775:1113/075750.234915:VERBOSE3:client.cc(626)] Successfully loaded client state
[1818:775:1113/075750.234964:VERBOSE3:confirmations.cc(207)] Loading confirmations state
[1818:775:1113/075750.235241:VERBOSE3:confirmations.cc(217)] Confirmations state does not exist, creating default state
[1818:775:1113/075750.235350:VERBOSE3:ad_notifications.cc(324)] Loading ad notifications state
[1818:775:1113/075750.243042:VERBOSE3:ad_notifications.cc(350)] Successfully loaded ad notifications state
[1818:775:1113/075750.243106:VERBOSE3:ad_conversions.cc(380)] Loading ad conversions state
[1818:775:1113/075750.243708:VERBOSE3:ad_conversions.cc(406)] Successfully loaded ad conversions state
[1818:775:1113/075750.243767:VERBOSE1:ads_impl.cc(212)] Successfully initialized ads

Confirmed that after updating to 1.17.x, ads were being displayed as per the following:

[1818:775:1113/080013.444596:VERBOSE1:ads_impl.cc(1149)] Ad notification shown:
  uuid: 5b3460ed-1554-434f-b766-1d6182b548fb
  creativeInstanceId: 40a16e47-2ee4-44ff-a120-b761e29551b4
  creativeSetId: 6256002e-a7dd-4bb4-8853-0ae7bb9cb833
  campaignId: 42458d7e-eba5-4537-823d-ffca381d2b3b
  category: technology & computing
  title: $10 Credit from Nexo!
  body: Borrow as little as of $10 in stablecoins now.
2. Re-enable Ads via NTP widget

Installed 1.14.19, enabled Rewards. Disabled Ads via brave://rewards.
Closed Brave and renamed profile to Brave-Browser.
Launched with 1.17.x build above and enabled Ads via NTP widget.
Confirmed ads were being initialized per the following:

[2010:775:1113/082134.266255:VERBOSE1:ads_impl.cc(136)] Initializing ads
[2010:775:1113/082134.266645:VERBOSE1:purchase_intent_classifier.cc(340)] Successfully loaded kkjipiepeooghlclkedllogndmohhnhi purchase intent user model
[2010:775:1113/082134.267807:VERBOSE1:purchase_intent_classifier.cc(56)] Parsed purchase intent user model version 1 with a signal level of 1, classification threshold of 3 and a signal decay time window of 604800 seconds
[2010:775:1113/082134.267892:VERBOSE1:purchase_intent_classifier.cc(348)] Successfully initialized kkjipiepeooghlclkedllogndmohhnhi purchase intent user model
[2010:775:1113/082134.308307:VERBOSE1:page_classifier.cc(151)] Successfully loaded emgmepnebbddgnkhfmhdhmjifkglkamo page classification user model
[2010:775:1113/082134.599597:VERBOSE1:page_classifier.cc(160)] Successfully initialized emgmepnebbddgnkhfmhdhmjifkglkamo page classification user model
[2010:775:1113/082134.601505:VERBOSE1:database_migration.cc(51)] Migrated database from version 1 to version 3
[2010:775:1113/082134.608715:VERBOSE3:client.cc(600)] Loading client state
[2010:775:1113/082134.609518:VERBOSE3:client.cc(626)] Successfully loaded client state
[2010:775:1113/082134.609568:VERBOSE3:confirmations.cc(207)] Loading confirmations state
[2010:775:1113/082134.609893:VERBOSE3:confirmations.cc(217)] Confirmations state does not exist, creating default state
[2010:775:1113/082134.609998:VERBOSE3:ad_notifications.cc(324)] Loading ad notifications state
[2010:775:1113/082134.618357:VERBOSE3:ad_notifications.cc(350)] Successfully loaded ad notifications state
[2010:775:1113/082134.618406:VERBOSE3:ad_conversions.cc(380)] Loading ad conversions state
[2010:775:1113/082134.619054:VERBOSE3:ad_conversions.cc(406)] Successfully loaded ad conversions state
[2010:775:1113/082134.619099:VERBOSE1:ads_impl.cc(212)] Successfully initialized ads

Confirmed that after updating to 1.17.x, ads were being displayed as per the following:

[2010:775:1113/082252.773804:VERBOSE1:ads_impl.cc(1149)] Ad notification shown:
  uuid: da9cf42e-9618-4caf-99f8-11fdae5787b5
  creativeInstanceId: 3e2ff62f-3c6d-4412-a143-6a5853fd117e
  creativeSetId: 32329ab4-9817-4f4b-bc6d-440c45ab95d0
  campaignId: 12e0d48a-bfe9-4980-8b94-e10a3b165540
  category: personal finance
  title: BlockFi
  body: Tired of not earning interest on your crypto? Try BlockFi

Verification passed on

Brave 1.17.68 Chromium: 87.0.4280.49 (Oficjalna wersja) (64-bitowa)
Wersja f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
System operacyjny Windows 7 Service Pack 1 (Build 7601.24544)

Verified STR from #12260 (comment)

Confirmed re-enabling ads from 2 ways:

1. Re-enable Ads via brave://rewards page

Installed 1.14.19, enabled Rewards. Disabled Ads via brave://rewards.
Closed Brave and renamed profile to Brave-Browser.
Launched with 1.17.x build above and enabled Ads via brave://rewards page.
Confirmed ads were being initialized per the following:

[5232:11780:1116/012230.849:VERBOSE1:ads_impl.cc(136)] Initializing ads
[5232:11780:1116/012231.872:VERBOSE1:database_migration.cc(51)] Migrated database from version 1 to version 3
[5232:11780:1116/012232.504:VERBOSE1:ads_impl.cc(321)] Browser window did enter background
[5232:11780:1116/012232.634:VERBOSE3:client.cc(600)] Loading client state
[5232:11780:1116/012232.635:VERBOSE3:client.cc(626)] Successfully loaded client state
[5232:11780:1116/012232.635:VERBOSE3:confirmations.cc(207)] Loading confirmations state
[5232:11780:1116/012232.635:VERBOSE3:confirmations.cc(217)] Confirmations state does not exist, creating default state
[5232:11780:1116/012232.635:VERBOSE3:ad_notifications.cc(324)] Loading ad notifications state
[5232:11780:1116/012232.863:VERBOSE3:ad_notifications.cc(350)] Successfully loaded ad notifications state
[5232:11780:1116/012232.863:VERBOSE3:ad_conversions.cc(380)] Loading ad conversions state
[5232:11780:1116/012232.864:VERBOSE3:ad_conversions.cc(406)] Successfully loaded ad conversions state
[5232:11780:1116/012232.864:VERBOSE1:ads_impl.cc(212)] Successfully initialized ads

Confirmed that after updating to 1.17.x, ads were being displayed as per the following:

[5232:11780:1116/012704.052:VERBOSE1:ads_impl.cc(1149)] Ad notification shown:
  uuid: 1c7ecf5b-e9d6-420e-8db1-b556663d0e59
  creativeInstanceId: 7dece232-3bf0-4ef1-9c95-3c0b66937877
  creativeSetId: 32439113-32d2-4b50-9497-405b7eedd1d5
  campaignId: dbd742cc-7bcf-47c8-aeed-5a8be10c7261
  category: untargeted
  title: HOOCH
  body: Gift free drinks and hotel deals this holiday, learn more now!
  targetUrl: https://travala.com/
2. Re-enable Ads via NTP widget

Installed 1.14.19, enabled Rewards. Disabled Ads via brave://rewards.
Closed Brave and renamed profile to Brave-Browser.
Launched with 1.17.x build above and enabled Ads via NTP widget.
Confirmed ads were being initialized per the following:

[11372:9220:1116/012945.420:VERBOSE1:ads_impl.cc(136)] Initializing ads
[11372:9220:1116/012945.422:VERBOSE1:database_migration.cc(51)] Migrated database from version 1 to version 3
[11372:9220:1116/012945.738:VERBOSE3:client.cc(600)] Loading client state
[11372:9220:1116/012945.738:VERBOSE3:client.cc(626)] Successfully loaded client state
[11372:9220:1116/012945.739:VERBOSE3:confirmations.cc(207)] Loading confirmations state
[11372:9220:1116/012945.739:VERBOSE3:confirmations.cc(217)] Confirmations state does not exist, creating default state
[11372:9220:1116/012945.739:VERBOSE3:ad_notifications.cc(324)] Loading ad notifications state
[11372:9220:1116/012945.842:VERBOSE3:ad_notifications.cc(350)] Successfully loaded ad notifications state
[11372:9220:1116/012945.842:VERBOSE3:ad_conversions.cc(380)] Loading ad conversions state
[11372:9220:1116/012945.843:VERBOSE3:ad_conversions.cc(406)] Successfully loaded ad conversions state
[11372:9220:1116/012945.843:VERBOSE1:ads_impl.cc(212)] Successfully initialized ads

Confirmed that after updating to 1.17.x, ads were being displayed as per the following:

[11372:9220:1116/013328.914:VERBOSE1:ads_impl.cc(1149)] Ad notification shown:
  uuid: a3271f96-f5ba-4975-a527-309593e5328f
  creativeInstanceId: bc6523ee-a790-487a-bb0e-7fda52b8af7e
  creativeSetId: 32439113-32d2-4b50-9497-405b7eedd1d5
  campaignId: dbd742cc-7bcf-47c8-aeed-5a8be10c7261
  category: untargeted
  title: HOOCH
  body: The perfect last minute gift idea, click now for details!
  targetUrl: https://travala.com/

@LaurenWags LaurenWags mentioned this issue Nov 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug feature/ads OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Ads
Archived in project
Milestone
1.17.x - Release #1
4 participants
@tmancey @kjozwiak @LaurenWags @btlechowski