Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Maps trackpad zoom is oversensitive #12310

Closed
stshank opened this issue Oct 24, 2020 · 37 comments · Fixed by brave/brave-core#7026
Closed

Google Maps trackpad zoom is oversensitive #12310

stshank opened this issue Oct 24, 2020 · 37 comments · Fixed by brave/brave-core#7026
Assignees
@pes10k
Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include trackpad webcompat/shields Shields is breaking a website.
Milestone
1.17.x - Release #1

Comments

@stshank
Copy link

stshank commented Oct 24, 2020

Description

Google Maps zoom is very twitchy with two-finger drag up and down on trackpad.

Steps to Reproduce

  1. Open maps.google.com
  2. Zoom in or out by swiping two fingers up or down

Actual result:

Map view jumps dramatically across several levels of zoom.

Expected result:

Map view gradually zooms in or out.

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.17.48 Chromium: 86.0.4240.111 (Official Build) dev (x86_64)
Revision b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS macOS Version 10.15.7 (Build 19H2)

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    no

  • Is the issue reproducible on the latest version of Chrome?
    no

Miscellaneous Information:

Using the + and - buttons on the website interface is a workaround, though it loses zoom animation steps that Chrome shows during the zoom level transition.
@rebron rebron added needs-investigation A bug not 100% confirmed/fixed priority/P3 The next thing for us to work on. It'll ride the trains. labels Oct 27, 2020
@kjozwiak
Copy link
Member

Running into the above as well. It becomes really painful to use Google Maps. Takes a lot of patience to actually get it zoomed to your desired view. I just started using Google Maps on mobile instead when I need to check something quickly.

Reproduced on macOS 10.15.7 x64 using the following build:

Brave | 1.18.10 Chromium: 86.0.4240.111 (Official Build) nightly (x86_64)
-- | --
Revision | b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS | macOS Version 10.15.7 (Build 19H2)

Also seems to be happening on Win 10 x64 when using the trackpad. However, when you use a mouse with a wheel, experience is pretty good.

@kjozwiak kjozwiak removed the OS/macOS label Oct 27, 2020
@kjozwiak
Copy link
Member

@rebron mind checking this on your Win 10 x64 laptop? Do you get the same experience/results when using the trackpad?

@rebron rebron changed the title Google Maps trackpad zoom is oversensitive on MacOS Google Maps trackpad zoom is oversensitive Oct 28, 2020
@rebron
Copy link
Collaborator

rebron commented Oct 28, 2020

@kjozwiak Same fast zoom on Windows. I'm actually missing a "slow streets" layer as well which is showing up in Chrome. There is a slower, smoother scrolling.

cc: @pes10k @pilgrim-brave Any ideas on this one? maps.google.com has a smoother/slower zoom in/out behavior via trackpad on Windows or macOS in comparison to us where it's a much more faster/extreme zoom.

@darkdh
Copy link
Member

darkdh commented Oct 28, 2020 •
edited
Loading

If you take a closer look on zoom factor of url address, Brave increase/decrease the factor by 1, while other browsers can do it by granular fraction

@fabricapo
Copy link

fabricapo commented Oct 30, 2020 •
edited
Loading

+1 on this one. It makes me consider going back to Google Chrome, sadly. I am on MacOS Catalina 10.15.7 with a magic trackpad, Brave Version 1.16.68 Chromium: 86.0.4240.111 (Official Build) (x86_64)

@kaytwo
Copy link

kaytwo commented Nov 2, 2020

Can y'all check whether GPU rendering is available on Google Maps? Switch to satellite view -> check the lower right hand corner for "3D Earth is not available" text. If the text is there, then you're using the tile based map rather than the vector/GPU based map which has far fewer features.

I think these complaints are all a symptom of a much more annoying problem, that Google Maps isn't serving the GPU accelerated version of the app to Brave. That feature enables fractional zoom, 3d buildings, and a lot of other QOL stuff.

@fabricapo
Copy link

Nope, I do not see the "3D Earth is not available" text when I switch to Satellite view.

"Google Maps isn't serving the GPU accelerated version of the app to Brave" means it will never happen, or do you think there will be a trick to activate it? If the probability is low, I'll move back to Chrome (sadly)

@stshank
Copy link
Author

stshank commented Nov 2, 2020 via email

@pes10k
Copy link
Contributor

pes10k commented Nov 2, 2020

Hi @stshank @kaytwo and @fabricapo, i have a candidate for the issue here (looks like one of our WebGL related fingerprinting protections is getting applied w/o checking whether shields is at "default" or "max" protections). Im working testing a fix now and hope to have a solution (or at least crossed off a potential cause) shortly. Thanks all for your help!

@kaytwo
Copy link

kaytwo commented Nov 2, 2020

Awesome! FYI I run www.google.com with shields down and am still seeing this issue. Feel free to ask for more info.

@pes10k pes10k mentioned this issue Nov 3, 2020
Merged
33 tasks
@pes10k pes10k self-assigned this Nov 3, 2020
@pes10k pes10k added feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields webcompat/shields Shields is breaking a website. QA/Yes release-notes/include and removed needs-investigation A bug not 100% confirmed/fixed labels Nov 3, 2020
@pes10k pes10k added this to the 1.18.x - Nightly milestone Nov 3, 2020
pes10k added a commit to brave/brave-core that referenced this issue Nov 3, 2020
@pes10k
check shield fingerprint status before blocking WebGL sharder API, fixes
3816626 
 brave/brave-browser#12310
@rebron
Copy link
Collaborator

rebron commented Nov 16, 2020

Verified that zooming in and out is looking good for me, smoother scrolling as expected versus scrolling several levels on swipe up/down or pinch on:

Brave 1.17.69 Chromium: 87.0.4280.60 (Official Build) (x86_64)
Revision 12697cfeb273d7de95cf9b18350d2c457f58224c-refs/branch-heads/4280@{#1352}
OS macOS Version 11.0.1 (Build 20B29)

@stshank
Copy link
Author

stshank commented Nov 16, 2020 via email

@kjozwiak
Copy link
Member

kjozwiak commented Nov 17, 2020 •
edited
Loading

Verification PASSED on macOS 10.15.7 x64 using the following build:

Brave | 1.17.69 Chromium: 87.0.4280.60 (Official Build) (x86_64)
-- | --
Revision | 12697cfeb273d7de95cf9b18350d2c457f58224c-refs/branch-heads/4280@{#1352}
OS | macOS Version 10.15.7 (Build 19H2)

Ensured that zooming in/out via the mouse/trackpad wasn't as sensitive as before.

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.17.69 Chromium: 87.0.4280.60 (Official Build) (64-bit)
-- | --
Revision | 12697cfeb273d7de95cf9b18350d2c457f58224c-refs/branch-heads/4280@{#1352}
OS | Windows 10 OS Version 2009 (Build 19042.630)

Ensured that zooming in/out via the mouse/trackpad wasn't as sensitive as before.

@LaurenWags LaurenWags mentioned this issue Nov 18, 2020
Closed
@LaurenWags LaurenWags mentioned this issue Nov 18, 2020
Closed
@mattmodarres
Copy link

mattmodarres commented Nov 30, 2020 •
edited
Loading

I'm still experiencing this issue with Brave 1.17.73 on Mac OS 11.0.1.

Brave | 1.17.73 Chromium: 87.0.4280.67 (Official Build) (x86_64)
-- | --
Revision | 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS | macOS Version 11.0.1 (Build 20B50)

@pes10k
Copy link
Contributor

pes10k commented Nov 30, 2020

@mattmodarres do you have strict / max fingerprinting protections? If so, then this is not a bug; those are advertised as potentially breaking sites.

if you're seeing the issue in the default configuration, please let us know

@iatenothingbutriceforthreedays
Copy link

I am experiencing this same issue with Brave 1.43.89 on Mac OS 10.14.6. Scroll-to-zoom is way too sensitive and there's no smooth transition between zoom levels.
I have fingerprinting protections set to Standard, and disabling those makes no difference to the issue.

@pes10k
Copy link
Contributor

pes10k commented Sep 5, 2022

@iatenothingbutriceforthreedays do you have other extensions installed? I am testing with a similar setup and cannot reproduce once i let google maps full load. Can you double check you can reproduce with no extensions enabled and all browser settings at default?

@pasolid
Copy link

pasolid commented Dec 6, 2022 •
edited
Loading

I started experiencing the same issue after updating Brave to 1.45.134 on MacOS 12.5 Monterey.
Supper inconvenient. It's like I'm jumping from world view to closest view with hardly swiping on the trackpad (both magic pad and mac pad).

I don't have any particular extension installed. Nothing changed in extensions list between normal behavior to current state

@pes10k
Copy link
Contributor

pes10k commented Dec 8, 2022

@pasolid do you have fingerprinting protections in the default setting, or the aggressive setting? If the latter, this is *(unfortunately) expected behavior. The choppy scrolling is what Google Maps does if you don't report information about your graphics card to Google

@tylerpharand
Copy link

In case it helps anyone, I recently started using the ScrollMaps extension to work around this issue. It uses a pinch gesture for zooming and is way less sensitive.

@NayamAmarshe
Copy link

Still an issue on Linux.

@pes10k
Copy link
Contributor

pes10k commented Jan 3, 2023 via email

@NayamAmarshe
Copy link

If folks have aggressive fingerprinting protections enabled, this is not a bug, it’s expected behavior. If you have standard fingerprinting protections enabled, please confirm with the version and we’ll get it sorted. Thanks!On Jan 3, 2023, at 13:59, NayamAmarshe @.> wrote: Still an issue on Linux. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were assigned.Message ID: @.>

Ah thanks for the reply. I checked and yes, it indeed was set to 'block aggressive fingerprinting'. It's much smoother now. Thanks a lot! I'm on v1.46.144 btw.

@NayamAmarshe
Copy link

This problem has returned, not sure why. I'm on v1.52.126. Even after turning off shields, enabling/disabling HW acceleration, google maps zoom is jumpy.

I'm on Manjaro Wayland.

@kjozwiak
Copy link
Member

kjozwiak commented Jul 6, 2023

This problem has returned, not sure why. I'm on v1.52.126. Even after turning off shields, enabling/disabling HW acceleration, google maps zoom is jumpy.

I'm on Manjaro Wayland.

@NayamAmarshe mind creating a new issue (similar to this one) here. Once created, we'll see if we can reproduce/triage if needed.

@michaeltrollan
Copy link

michaeltrollan commented Jul 15, 2024 •
edited
Loading

For anyone who ends up in this issue and none of the other solutions are working, here is a short guide:

First, try going to Google Maps in an incognito window. (File > New Private Window). If the scrolling is smooth there, then likely it's a settings issue, and you might be seeing the "lite" version of Google Maps.

You can tell by whether 3D is available in Satellite view. If it's not, this YouTube video has 9 possible solutions. https://www.youtube.com/watch?v=n5skrIePo50

(For me, it was the 2nd solution that fixed the scrolling bug in Brave. The issue occasionally comes back, but the link then fixes it again.)

@mohith7548
Copy link

https://www.google.com/maps?force=webgl worked for me.

@NayamAmarshe
Copy link

https://www.google.com/maps?force=webgl worked for me.

Oh wow! Thank you, this works well! How did you find it?

@michaeltrollan
Copy link

michaeltrollan commented Sep 12, 2024 •
edited
Loading

https://www.google.com/maps?force=webgl worked for me.

Oh wow! Thank you, this works well! How did you find it?

It was option 2 in the YouTube video linked above. https://www.youtube.com/watch?v=n5skrIePo50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pes10k pes10k

Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include trackpad webcompat/shields Shields is breaking a website.
Projects
None yet
Milestone
1.17.x - Release #1
Development

Successfully merging a pull request may close this issue.

check shield setting before blocking WebGL shader API brave/brave-core