Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable customise top tiles hide it completely #12354

Closed
srirambv opened this issue Oct 28, 2020 · 2 comments · Fixed by brave/brave-core#7105
Closed

Enable customise top tiles hide it completely #12354

srirambv opened this issue Oct 28, 2020 · 2 comments · Fixed by brave/brave-core#7105

Comments

@srirambv
Copy link
Contributor

Description

Enable customise top tiles hide it completely

Steps to Reproduce

  1. Upgrade to 1.18.12 nightly build
  2. Open NTP and go to dashboard settings
  3. Disable customise top tiles from settings, top tiles are disabled

Actual result:

toptiles

Expected result:

Should not hide tiles when customise is selected

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.18.12 Chromium: 86.0.4240.111 (Official Build) nightly (64-bit)
Revision b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @bsclifton

@bsclifton
Copy link
Member

Diagnosed with @srirambv - I believe the root cause for this is that clear on exit is set for him

You can view the data that SHOULD be showing on custom links via brave://ntp-tiles-internals/ and this (along with brave://new-tab-page) is blank. When doing the add/edit tile issue (#7493), we'll want to make sure that custom entries persist with clear on exit set

@LaurenWags
Copy link
Member

LaurenWags commented Nov 18, 2020

Verified passed with

Brave | 1.17.70 Chromium: 87.0.4280.60 (Official Build) (x86_64)
-- | --
Revision | 12697cfeb273d7de95cf9b18350d2c457f58224c-refs/branch-heads/4280@{#1352}
OS | macOS Version 10.14.6 (Build 18G6042)

Verified test plan from brave/brave-core#7105

Confirmed the Customize Top Sites toggle under the Customization modal as been removed:
Screen Shot 2020-11-18 at 11 29 47 AM

Confirmed that use_most_visited_tiles is set as true under brave://prefs-internals:
Screen Shot 2020-11-18 at 11 29 24 AM


Verification passed on

Brave 1.17.70 Chromium: 87.0.4280.60 (Official Build) (64-bit)
Revision 12697cfeb273d7de95cf9b18350d2c457f58224c-refs/branch-heads/4280@{#1352}
OS Windows 7 Service Pack 1 (Build 7601.24544)

Verified test plan from brave/brave-core#7105

Confirmed the Customize Top Sites toggle under the Customization modal as been removed:
image

Confirmed that use_most_visited_tiles is set as true under brave://prefs-internals:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants