Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] location service status is mismatched in bubble and URL icon #12766

Open
LaurenWags opened this issue Nov 18, 2020 · 1 comment
Open
Labels
feature/geolocation OS/Desktop OS/macOS priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes

Comments

@LaurenWags
Copy link
Member

Description

If you have location services enabled (System Preferences > Security and Privacy > Privacy) and Brave Browser is allowed to use them, sometimes you can get a mismatch in Brave's UI which is confusing.

Steps to Reproduce

  1. Clean install 1.17.70
  2. Navigate to http://browserleaks.com/geo
  3. Allow browserleaks to know your location. Now look to right side of URL bar and see that URL bar icon/bubble directs you to enable Location Services. Enable them in settings.
  4. Close Brave, delete your profile.
  5. Launch 1.17.70 again with clean profile.
  6. Navigate to http://browserleaks.com/geo
  7. Allow location services.
  8. URL bar bubble tells me location is off, however if you wait a few seconds it does find your location.

Actual result:

URL bar icon/bubble looks like this - note icon in the blue box:
mismatch

Expected result:

If location services were truly off/Brave was not allowed to access, it should look like this:
image

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.17.70 Chromium: 87.0.4280.60 (Official Build) (x86_64)
Revision 12697cfeb273d7de95cf9b18350d2c457f58224c-refs/branch-heads/4280@{#1352}
OS macOS Version 10.14.6 (Build 18G6042)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a 1.16.x, yes 1.17.x
  • Can you reproduce this issue with the beta channel? yes 1.18.x
  • Can you reproduce this issue with the nightly channel? yes, 1.19.x

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @kjozwiak as he reproduced

@rebron
Copy link
Collaborator

rebron commented Nov 23, 2020

cc: @simonhong. I'm seeing this as well. Allowed to use in system settings but getting that prompt that it's turned off.

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/geolocation OS/Desktop OS/macOS priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes
Projects
Status: P3 Backlog
Development

No branches or pull requests

2 participants