Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor BraveAds to use chrome::GetChannelName instead of brave::GetChannelName to remove layering violation #12768

Closed
tmancey opened this issue Nov 18, 2020 · 1 comment
Closed

Refactor BraveAds to use chrome::GetChannelName instead of brave::GetChannelName to remove layering violation #12768

tmancey opened this issue Nov 18, 2020 · 1 comment
Assignees
@aseren
Labels
closed/duplicate Issue has already been reported dev-concern feature/ads OS/Desktop

Comments

@tmancey
Copy link
Contributor

tmancey commented Nov 18, 2020

chrome::GetChannelName should be passed to AdsServiceImpl in the factory to eliminate this layering violation
@tmancey tmancey changed the title Refactor BraveAds to use chrome::GetChannelName instead of brave::GetChannelName Refactor BraveAds to use chrome::GetChannelName instead of brave::GetChannelName to remove layering violation Nov 18, 2020
@tmancey tmancey mentioned this issue Nov 18, 2020
Merged
32 tasks
@tmancey tmancey added the closed/duplicate Issue has already been reported label Aug 23, 2021
@tmancey
Copy link
Contributor Author

tmancey commented Aug 23, 2021

Closing issue as a duplicate of #17632

@tmancey tmancey closed this as completed Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
closed/duplicate Issue has already been reported dev-concern feature/ads OS/Desktop
Projects
Ads
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmancey @aseren