Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor BraveRewards to use chrome::GetChannelName instead of brave::GetChannelName to remove layering violation #12769

Closed
tmancey opened this issue Nov 18, 2020 · 3 comments
Closed

Refactor BraveRewards to use chrome::GetChannelName instead of brave::GetChannelName to remove layering violation #12769

tmancey opened this issue Nov 18, 2020 · 3 comments
Labels
closed/wontfix dev-concern feature/rewards OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@tmancey
Copy link
Contributor

tmancey commented Nov 18, 2020 •
edited
Loading

chrome::GetChannelName should be passed to RewardsServiceImpl in the factory to eliminate this layering violation
@tmancey tmancey changed the title Refactor BraveAds to use chrome::GetChannelName instead of brave::GetChannelName Refactor BraveRewards to use chrome::GetChannelName instead of brave::GetChannelName Nov 18, 2020
@tmancey tmancey changed the title Refactor BraveRewards to use chrome::GetChannelName instead of brave::GetChannelName Refactor BraveRewards to use chrome::GetChannelName instead of brave::GetChannelName to remove layering violation Nov 18, 2020
@tmancey tmancey mentioned this issue Nov 18, 2020
Merged
32 tasks
@marshall marshall added the needs-more-info The report requires more detail before we can decide what to do with this issue. label Nov 25, 2020
@marshall
Copy link

marshall commented Dec 7, 2020

Reference from an older PR: brave/brave-core#5067 (comment)

@marshall marshall added dev-concern priority/P3 The next thing for us to work on. It'll ride the trains. and removed needs-more-info The report requires more detail before we can decide what to do with this issue. labels Dec 7, 2020
@emerick
Copy link
Contributor

emerick commented Dec 10, 2020

@tmancey Is this issue still relevant? I can't find any reference to GetChannelName in the Rewards service anymore...

@tmancey
Copy link
Contributor Author

tmancey commented Dec 11, 2020

@emerick Thanks. I will close this issue as brave::GetChannelName was moved when transitioning Confirmations from ledger to ads.

@tmancey tmancey closed this as completed Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/wontfix dev-concern feature/rewards OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marshall @tmancey @emerick