Hide in-line tipping buttons for users who've already hidden the BAT / Brave Rewards icon #13341

Miyayes · 2020-12-30T20:53:28Z

Description

In a recent update, in-line tipping buttons were made to appear by default in Brave. For users who had already disabled the BAT/Brave Rewards icon in their browser, in-line tip buttons should not have appeared, as those users had already expressed a desire to opt out of Brave Rewards-related features.

Additionally, disabling in-line tipping buttons for these users was made more difficult by the fact that they could not access the Brave Rewards settings page via the usual method: namely, clicking on the very BAT/Brave Rewards icon that they had already hidden.

Proposed solution

For users who have already disabled the BAT/Brave Rewards icon, roll back and hide the in-line tipping buttons.

(Any other expressions of opting out equivalent to disabling the BAT/Brave Rewards icon should also be considered.)

Related discussion

#13222

Some similar reports on Reddit.

resynth1943 · 2021-01-08T19:52:27Z

So, let's say someone creates a new Brave profile. Judging by the premise of this issue, the advertisements would still be enabled.

What would happen if they then went on to disable the Rewards icon after this feature was enabled? I'm presuming this aspect hasn't been considered; in that case, perhaps it would be wise to have a tete-a-tete with the Rewards Settings to disable this option too?

Any feedback / opinions on this?

Miyayes · 2021-01-08T20:04:21Z

@resynth1943, when you say "new profile" do you mean just a new profile for an existing user, or do you mean a brand new user who's downloaded Brave for the first time?

@emerick I think if a user disables the Brave Rewards/BAT icon, in-line tipping buttons should also be hidden. It should be considered a full opt-out. It would cause the same problem again if they went and disabled the Brave Rewards/BAT icon before going into brave://rewards Tipping settings and disabling the in-line tips.

resynth1943 · 2021-01-08T20:07:20Z

@Miyayes aren't they the same thing though? Both avenues lead to a fresh profile, so in theory they should emit the same results. I meant both. 🙂 Theoretically speaking they both equate to a new user, too.

That being said, I'm not entirely sure if Rewards should be disabled in new profiles, if the profile they were created from has Rewards disabled. I'll leave that to the Brave team to decide. 🤷‍♂️

Miyayes · 2021-01-15T02:02:31Z

@resynth1943 Thanks for your comments. Just to clarify: a decision was made to have tipping buttons appear by default in Brave. It is a gateway to help new and existing users find and learn about Brave Rewards. However, the buttons should not have appeared for users who had already chosen to hide the Brave Rewards (BAT) icon in the URL bar (which is equivalent to an explicit expression of opting out).

Two things to note:

The Brave Rewards master on/off toggle doesn't exist anymore, so it's kind of anachronistic to speak of "Brave Rewards is disabled". Only individual components in BR have an on/off toggle now (like Brave Ads, which is off by default).
Brave Rewards was always off by default since the beginning. So, speaking of "users who had Brave Rewards disabled" needs to be broken out into two categories: (i) those who enabled Brave Rewards once in their life and then turned it off, and (ii) those who never enabled it from the beginning. (Third category would be users who hid the Brave Rewards icon in the URL bar.)

Category (i) should probably have the tipping buttons hidden too. However, not sure how feasible it would be to go back and try to track those state changes.

Category (ii) fall under the intentional design choice that was made to have the tip buttons appear.

Category (iii) are the ones directly addressed in this issue, and the tip icons should be hidden for them and shouldn't have appeared from the beginning.

It seems like a fresh profile (not new installation) might fall under (i) or (iii), but I think a fresh profile should be really just that: a fresh profile that doesn't carry over any preferences or settings from previous profiles. That would set all their settings/preferences to the defaults. And the defaults would entail tipping buttons showing by default.

GeetaSarvadnya · 2021-02-01T17:17:16Z

Verification passed on


Brave | 1.20.93 Chromium: 88.0.4324.96 (Official Build) dev (64-bit)
-- | --
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | Windows 10 OS Version 2004 (Build 19041.746)

Verified the test plan from Hide inline tipping buttons when Rewards icon is hidden brave-core#7655

Clean profile

Inline tip for Twitter

Ensured Inline tip icon has appeared for Twitter feeds by default when Rewards is enabled

Ensured Inline tip icon has appeared for Twitter tweets by default when Rewards is enabled

Ensured Inline tip icon hasn't appeared for Twitter feeds when Brave Rewards button is hidden via brave://settings/appearance

Ensured Inline tip icon hasn't appeared for Twitter tweets when Brave Rewards button is hidden via brave://settings/appearance

Restart the browser and ensured the inline tip icon is still not shown
Enable the Rewards button via brave://settings/appearance and restart the browser and ensured the inline tip button is shown

Inline tip for Reddit

Ensured Inline tip icon has appeared for Reddit by default when Rewards is enabled

Ensured Inline tip icon has appeared for Reddit posts by default when Rewards is enabled

Ensured Inline tip icon hasn't appeared for Reddit feeds when Brave Rewards button is hidden via brave://settings/appearance

Ensured Inline tip icon hasn't appeared for Reddit posts when Brave Rewards button is hidden via brave://settings/appearance

Restart the browser and ensured inline tip icon is still not shown
Enable the Rewards button via brave://settings/appearance and restart the browser and ensured inline tip button is shown

Inline tip for Github_stars tab of user profile

Ensured Inline tip icon has appeared for GH stars tab of the user profile when Rewards is enabled

Ensured Inline tip icon hasn't appeared for GH stars tab when Brave Rewards button is hidden via brave://settings/appearance

Restart the browser and ensured the inline tip icon is still not shown
Enable the Rewards button via brave://settings/appearance and restart the browser and ensured the inline tip button is shown

Inline tip for Github_commits > branch name

Ensured Inline tip icon has appeared for GH commits page when Rewards is enabled

Ensured Inline tip icon hasn't appeared for GH commits page when Brave Rewards button is hidden via brave://settings/appearance

Restart the browser and ensured the inline tip icon is still not shown
Enable the Rewards button via brave://settings/appearance and restart the browser and ensured the inline tip button is shown

Inline tip for Github_Issues page

Ensured Inline tip icon has appeared for GH Issues page when Rewards is enabled

Ensured Inline tip icon hasn't appeared for GH Issues page when Brave Rewards button is hidden via brave://settings/appearance

Restart the browser and ensured the inline tip icon is still not shown
Enable the Rewards button via brave://settings/appearance and restart the browser and ensured the inline tip button is shown

Inline tip for Github_PR page

Ensured Inline tip icon has appeared for GH PR page when Rewards is enabled

Ensured Inline tip icon hasn't appeared for GH Issues page when Brave Rewards button is hidden via brave://settings/appearance

Restart the browser and ensured the inline tip icon is still not shown
Enable the Rewards button via brave://settings/appearance and restart the browser and ensured the inline tip button is shown

Inline tip for Github_Teams page

Ensured Inline tip icon has appeared for GH PR page when Rewards is enabled

Ensured Inline tip icon hasn't appeared for GH Issues page when Brave Rewards button is hidden via brave://settings/appearance

Restart the browser and ensured the inline tip icon is still not shown
Enable the Rewards button via brave://settings/appearance and restart the browser and ensured the inline tip button is shown

Inline tip for Github_People page

Ensured Inline tip icon has appeared for GH People page when Rewards is enabled

Ensured Inline tip icon hasn't appeared for GH People page when Brave Rewards button is hidden via brave://settings/appearance

Restart the browser and ensured the inline tip icon is still not shown
Enable the Rewards button via brave://settings/appearance and restart the browser and ensured the inline tip button is shown

Encountered GH inline Tip button is removed after page reload #12383

Upgrade profile

Hide Rewards in 1.19.88 and then upgrade to 1.20.x

Inline tip icon is still shown in 1.19.88 even after hiding rewards via brave://settings/appearance
Restart 1.19.x still shows the inline tip icon
Upgraded to 1.20.x and ensured Inline tip icon hasn't appeared after upgrade

Do not hide Rewards in 1.19.88 upgrade to 1.20.x

Ensured Brave Rewards button is enabled after upgrade
Ensured inline tip icon is shown in Twitter/GH/Reddit feeds after upgrade
Restart the browser after the upgrade and ensured the inline tip icon is still shown in Twitter/GH/Reddit feeds

Hide Rewards and Tip settings in 1.19.88 and then upgrade to 1.20.x

Inline tip is shown for GH/Twitter/Reddit even after hiding rewards and Tip settings in 1.19.88
Ensured that inline tip is not shown for GH/Twitter/Reddit after upgrade

Encountered Inline tip button is shown in Reddit/Twitter/GH even though tipping is disabled in Tips settings #12870

Verification passed on

Brave	1.20.97 Chromium: 88.0.4324.96 (Official Build) dev (64-bit)
Revision	68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS	Ubuntu 18.04 LTS

Verified the test plan from Hide inline tipping buttons when Rewards icon is hidden brave-core#7655

Clean profile

Inline tip for Twitter

Ensured Inline tip icon has appeared for Twitter feeds by default when Rewards is enabled

Ensured Inline tip icon has appeared for Twitter tweets by default when Rewards is enabled

Ensured Inline tip icon hasn't appeared for Twitter feeds when Brave Rewards button is hidden via brave://settings/appearance

Ensured Inline tip icon hasn't appeared for Twitter tweets when Brave Rewards button is hidden via brave://settings/appearance

Restart the browser and ensured the inline tip icon is still not shown
Enable the Rewards button via brave://settings/appearance and restart the browser and ensured the inline tip button is shown

Inline tip for Reddit

Ensured Inline tip icon has appeared for Reddit by default when Rewards is enabled

Ensured Inline tip icon hasn't appeared for Reddit when Brave Rewards button is hidden via brave://settings/appearance

Restart the browser and ensured inline tip icon is still not shown
Enable the Rewards button via brave://settings/appearance and restart the browser and ensured inline tip button is shown

Inline tip for Github

stars tab of user profile

Ensured Inline tip icon has appeared for GH stars tab of the user profile when Rewards is enabled

Ensured Inline tip icon hasn't appeared for GH stars tab when Brave Rewards button is hidden via brave://settings/appearance

commits > branch name
Ensured Inline tip icon has appeared for GH commits page when Rewards is enabled

Ensured Inline tip icon hasn't appeared for GH commits page when Brave Rewards button is hidden via brave://settings/appearance

Issues page
Ensured Inline tip icon has appeared for GH Issues page when Rewards is enabled

Ensured Inline tip icon hasn't appeared for GH Issues page when Brave Rewards button is hidden via brave://settings/appearance

PR page
Ensured Inline tip icon has appeared for GH PR page when Rewards is enabled

Ensured Inline tip icon hasn't appeared for GH Issues page when Brave Rewards button is hidden via brave://settings/appearance

Teams page
Ensured Inline tip icon has appeared for GH PR page when Rewards is enabled

Ensured Inline tip icon hasn't appeared for GH Issues page when Brave Rewards button is hidden via brave://settings/appearance

People page
Ensured Inline tip icon has appeared for GH People page when Rewards is enabled

Ensured Inline tip icon hasn't appeared for GH People page when Brave Rewards button is hidden via brave://settings/appearance

Upgrade profile

Hide Rewards in 1.19.88 and then upgrade to 1.20.x

Inline tip icon is still shown in 1.19.88 even after hiding rewards via brave://settings/appearance
Upgraded to 1.20.x and ensured Inline tip icon hasn't appeared after upgrade

Do not hide Rewards in 1.19.88 upgrade to 1.20.x

Ensured Brave Rewards button is enabled after upgrade
Ensured inline tip icon is shown in Twitter/GH/Reddit feeds after upgrade
Restart the browser after the upgrade and ensured the inline tip icon is still shown in Twitter/GH/Reddit feeds

Hide Rewards and Tip settings in 1.19.88 and then upgrade to 1.20.x

Inline tip is shown for GH/Twitter/Reddit even after hiding rewards and Tip settings in 1.19.88
Ensured that inline tip is not shown for GH/Twitter/Reddit after upgrade

Verified using

Brave	1.20.98 Chromium: 88.0.4324.96 (Official Build) beta (x86_64)
Revision	68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS	macOS Version 10.15.7 (Build 19H15)

Verified scenarios listed in brave/brave-core#7655 (comment)

Scenario 1

1. Clean install 1.20.x (Beta). 2. Hid the Rewards icon via settings and restarted the browser. 3. Confirmed after restart in-line tip icons did not show on Twitter, GH, Reddit.

Twitter	Reddit	GitHub

Restarted the browser.
Confirmed in-line tip icons still not shown.
Re-enabled Rewards icon from settings.
Restart the browser.
Confirmed in-line tip icons show on Twitter, GH, Reddit.

Twitter	Reddit	GitHub

Scenario 2

Installed 1.19.90 (Release).
Hid the Rewards icon via settings.
Restarted 1.19.x, confirmed in-line tip icons still showed.

Twitter	Reddit	GitHub

Upgraded to 1.20.x.
Confirmed in-line tip icons no longer shown on Twitter, GH, Reddit.

Twitter	Reddit	GitHub

Scenario 3

Installed 1.19.90 (Release).
Hid the Rewards icon via settings.
Manually hid each in-line tip icon via Tips settings on brave://rewards page.
Restarted 1.19.x, confirmed in-line tip icons not shown.

Twitter	Reddit	GitHub

Upgraded to 1.20.x.
Confirmed in-line tip icons still not shown on Twitter, GH, Reddit.

Twitter	Reddit	GitHub

Scenario 4

Installed 1.19.90 (Release).
Confirmed Rewards icon not hidden.
Confirmed in-line tip icons shown on Twitter, GH, Reddit.

Twitter	Reddit	GitHub

Upgraded to 1.20.x.
Confirmed Rewards icon still visible.
Confirmed in-line tip icons still shown on Twitter, GH, Reddit.

Twitter	Reddit	GitHub

Miyayes added OS/Desktop feature/rewards greaselion labels Dec 30, 2020

emerick mentioned this issue Jan 8, 2021

Unsolicited Advertisements from Brave Rewards / Respecting the User's Choices #13222

Closed

emerick self-assigned this Jan 8, 2021

Miyayes mentioned this issue Jan 13, 2021

Brave Rewards' "Tip" button appears on Reddit, GitHub and Twitter even if I have disabled the Brave Rewards entirely #13157

Closed

Miyayes added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 15, 2021

emerick mentioned this issue Jan 19, 2021

Hide inline tipping buttons when Rewards icon is hidden brave/brave-core#7655

Merged

23 tasks

emerick added QA/Yes release-notes/include labels Jan 19, 2021

emerick closed this as completed in brave/brave-core#7655 Jan 19, 2021

emerick added this to the 1.21.x - Nightly milestone Jan 19, 2021

brave-builds mentioned this issue Jan 20, 2021

Hide inline tipping buttons when Rewards icon is hidden (uplift to 1.20.x) brave/brave-core#7672

Merged

4 tasks

kjozwiak modified the milestones: 1.21.x - Nightly, 1.20.x - Beta Jan 26, 2021

GeetaSarvadnya added the QA Pass-Win64 label Feb 2, 2021

btlechowski added the QA Pass-Linux label Feb 2, 2021

LaurenWags added the QA Pass-macOS label Feb 4, 2021

LaurenWags mentioned this issue Feb 8, 2021

[Desktop] Release Notes for 1.20.x Release #1 (Release Channel) #14035

Closed

emerick mentioned this issue Sep 8, 2021

Inline tip button is shown in Reddit/Twitter/GH even though tipping is disabled in Tips settings #12870

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hide in-line tipping buttons for users who've already hidden the BAT / Brave Rewards icon #13341

Hide in-line tipping buttons for users who've already hidden the BAT / Brave Rewards icon #13341

Miyayes commented Dec 30, 2020 •

edited

Loading

resynth1943 commented Jan 8, 2021

Miyayes commented Jan 8, 2021

resynth1943 commented Jan 8, 2021 •

edited

Loading

Miyayes commented Jan 15, 2021 •

edited

Loading

GeetaSarvadnya commented Feb 1, 2021 •

edited by LaurenWags

Loading

Hide in-line tipping buttons for users who've already hidden the BAT / Brave Rewards icon #13341

Hide in-line tipping buttons for users who've already hidden the BAT / Brave Rewards icon #13341

Comments

Miyayes commented Dec 30, 2020 • edited Loading

Description

Proposed solution

Related discussion

resynth1943 commented Jan 8, 2021

Miyayes commented Jan 8, 2021

resynth1943 commented Jan 8, 2021 • edited Loading

Miyayes commented Jan 15, 2021 • edited Loading

GeetaSarvadnya commented Feb 1, 2021 • edited by LaurenWags Loading

Miyayes commented Dec 30, 2020 •

edited

Loading

resynth1943 commented Jan 8, 2021 •

edited

Loading

Miyayes commented Jan 15, 2021 •

edited

Loading

GeetaSarvadnya commented Feb 1, 2021 •

edited by LaurenWags

Loading