Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New-tab page: failed to get and fire creative NTP ad and promoted content ad event #14194

Closed
stephendonner opened this issue Feb 16, 2021 · 1 comment

Comments

@stephendonner
Copy link

Description

In trying to test and verify #13695, I'm encountering Failed to get creative new tab page ad and Failed to fire promoted content ad event for uuid, when clicking on the promoted-content item on the new-tab page.

@tmancey can you confirm the optimal combination of command-line arguments for testing, if not as below? Thanks in advance!

In particular, in Failed to fire promoted content ad event for uuid, the uuid is missing a value.

Steps to Reproduce

  1. new profile, launch using --args --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=6,"*/brave_user_model/*"=6 --brave-ads-development --brave-ads-debug --rewards=development=true,reconcile-interval=5 --brave-today-host=brave-today-cdn.brave.software.

I've also tried using:
--args --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=6,"*/brave_user_model/*"=6 --brave-ads-debug --brave-today-host=brave-today-cdn.brave.software
but get the same errors.

  1. click Start using Brave Rewards
  2. open a new-tab page, and scroll down to a promoted-content item
  3. click on the promoted-content item

Screen Shot 2021-02-16 at 2 50 43 PM

Actual result:

[5890:775:0216/142737.798928:INFO:creative_promoted_content_ads_database_table.cc(427)] Failed to get creative new tab page ad
[5890:775:0216/142737.804062:VERBOSE1:promoted_content_ad.cc(75)] Failed to fire promoted content ad event for uuid
[5890:775:0216/142737.805287:VERBOSE1:ads_impl.cc(152)] Visited URL is not supported
[5890:775:0216/142738.452790:VERBOSE1:publisher.cc(515)] Publisher list is empty
[5890:775:0216/142738.453118:VERBOSE1:publisher.cc(515)] Publisher list is empty

Expected result:

I'd think I should see view and click events for the promoted-content item?

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.21.55 Chromium: 88.0.4324.152 (Official Build) beta (x86_64)
Revision 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS macOS Version 11.2.1 (Build 20D74)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes
@rebron rebron added the feature/brave-news formerly brave-today label Feb 18, 2021
@stephendonner
Copy link
Author

Closing this out; thx to a bunch of folks, we're now able to get matched ads to catalog, which was the problem, on dev/staging.

Working now:

[5941:775:0225/152300.378167:VERBOSE1:ad_transfer.cc(109)] Transfer ad for https://newsletter.banklesshq.com/p/defi-needs-trust-minimized-money in 0 hours, 0 minutes, 10 seconds at 3:23 PM
[5941:775:0225/152300.379956:VERBOSE1:conversions.cc(130)] Checking URL for conversions
[5941:775:0225/152300.380379:VERBOSE1:purchase_intent_processor.cc(97)] No purchase intent matches found for visited URL
[5941:775:0225/152300.532247:VERBOSE1:text_classification_processor.cc(62)] Classified text with the top segment as personal finance-personal finance
[5941:775:0225/152300.540404:VERBOSE1:conversions.cc(221)] No conversions found for visited URL
[5941:775:0225/152310.378807:VERBOSE1:ad_transfer.cc(140)] Transferred ad for https://newsletter.banklesshq.com/p/defi-needs-trust-minimized-money
[5941:775:0225/152310.378968:VERBOSE1:confirmations.cc(90)] Confirming landed ad for creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690
[5941:775:0225/152310.380003:VERBOSE1:redeem_unblinded_token.cc(49)] Redeem unblinded token
[5941:775:0225/152310.380071:VERBOSE1:redeem_unblinded_token.cc(63)] CreateConfirmation
[5941:775:0225/152310.380115:VERBOSE2:redeem_unblinded_token.cc(64)] POST /v1/confirmation/{confirmation_id}/{credential}
[5941:775:0225/152310.380156:VERBOSE5:redeem_unblinded_token.cc(68)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/afc3664d-44dc-4cdf-9d6c-4862e1717aff/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiYUpwWTJZdmZDcmhYTVZEd092MjRCaDMxWXJWd0xWUnJjazVNMmY1Q3R5az1cIixcImJ1aWxkQ2hhbm5lbFwiOlwicmVsZWFzZVwiLFwiY291bnRyeUNvZGVcIjpcIlVTXCIsXCJjcmVhdGl2ZUluc3RhbmNlSWRcIjpcIjQwYTY5ZmE5LTM4MTQtNGVjNC1iZWU4LWExNzZjOGZiNDY5MFwiLFwiZXhwZXJpbWVudFwiOnt9LFwicGF5bG9hZFwiOnt9LFwicGxhdGZvcm1cIjpcIm1hY29zXCIsXCJ0eXBlXCI6XCJsYW5kZWRcIn0iLCJzaWduYXR1cmUiOiJrU2Zsb0RXTFRwZ01IWTMxUWRURjZNbmJpSXUvK3FNeDFzR0UxNThNWUVlZ25uNDVzVTA5RXBKVVlVeWZXcUdHa211Y3hRYkZRYktVanU5TlpQeDdwdz09IiwidCI6IkpMbERrVHFDVkk2WlY3VjVIaElpYVJSakJSZzF0YmJZNmtGendmNFY5d0VPY25hcGNsb2FGa3FkdkgzMm4xTjhKTWpBdHJTcFZlZE1kVU9lZVZrTlpRPT0ifQ==
  Content: {"blindedPaymentToken":"aJpY2YvfCrhXMVDwOv24Bh31YrVwLVRrck5M2f5Ctyk=","buildChannel":"release","countryCode":"US","creativeInstanceId":"40a69fa9-3814-4ec4-bee8-a176c8fb4690","experiment":{},"payload":{},"platform":"macos","type":"landed"}
  Content Type: application/json
  Method: BraveAdsUrlRequestMethod::POST
[5941:775:0225/152310.387274:VERBOSE6:ad_transfer.cc(149)] Successfully logged transferred ad event
[5941:775:0225/152310.478893:VERBOSE1:redeem_unblinded_token.cc(81)] OnCreateConfirmation
[5941:775:0225/152310.479010:VERBOSE6:redeem_unblinded_token.cc(83)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/afc3664d-44dc-4cdf-9d6c-4862e1717aff/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiYUpwWTJZdmZDcmhYTVZEd092MjRCaDMxWXJWd0xWUnJjazVNMmY1Q3R5az1cIixcImJ1aWxkQ2hhbm5lbFwiOlwicmVsZWFzZVwiLFwiY291bnRyeUNvZGVcIjpcIlVTXCIsXCJjcmVhdGl2ZUluc3RhbmNlSWRcIjpcIjQwYTY5ZmE5LTM4MTQtNGVjNC1iZWU4LWExNzZjOGZiNDY5MFwiLFwiZXhwZXJpbWVudFwiOnt9LFwicGF5bG9hZFwiOnt9LFwicGxhdGZvcm1cIjpcIm1hY29zXCIsXCJ0eXBlXCI6XCJsYW5kZWRcIn0iLCJzaWduYXR1cmUiOiJrU2Zsb0RXTFRwZ01IWTMxUWRURjZNbmJpSXUvK3FNeDFzR0UxNThNWUVlZ25uNDVzVTA5RXBKVVlVeWZXcUdHa211Y3hRYkZRYktVanU5TlpQeDdwdz09IiwidCI6IkpMbERrVHFDVkk2WlY3VjVIaElpYVJSakJSZzF0YmJZNmtGendmNFY5d0VPY25hcGNsb2FGa3FkdkgzMm4xTjhKTWpBdHJTcFZlZE1kVU9lZVZrTlpRPT0ifQ==
  Response Status Code: 201
  Response: {"id":"afc3664d-44dc-4cdf-9d6c-4862e1717aff","payload":{},"createdAt":"2021-02-25T23:23:10.415Z","type":"landed","modifiedAt":"2021-02-25T23:23:10.415Z","creativeInstanceId":"40a69fa9-3814-4ec4-bee8-a176c8fb4690"}
[5941:775:0225/152310.479209:VERBOSE1:redeem_unblinded_token.cc(103)] FetchPaymentToken
[5941:775:0225/152310.479266:VERBOSE2:redeem_unblinded_token.cc(104)] GET /v1/confirmation/{confirmation_id}/paymentToken
[5941:775:0225/152310.479309:VERBOSE5:redeem_unblinded_token.cc(108)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/afc3664d-44dc-4cdf-9d6c-4862e1717aff/paymentToken
  Method: BraveAdsUrlRequestMethod::GET
[5941:775:0225/152310.536696:VERBOSE1:redeem_unblinded_token.cc(119)] OnFetchPaymentToken
[5941:775:0225/152310.536804:VERBOSE6:redeem_unblinded_token.cc(121)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/afc3664d-44dc-4cdf-9d6c-4862e1717aff/paymentToken
  Response Status Code: 200
  Response: {"id":"afc3664d-44dc-4cdf-9d6c-4862e1717aff","createdAt":"2021-02-25T23:23:10.415Z","type":"landed","modifiedAt":"2021-02-25T23:23:10.428Z","creativeInstanceId":"40a69fa9-3814-4ec4-bee8-a176c8fb4690","paymentToken":{"publicKey":"lLO5tErGoTK0askrALab6pKGAnBHqELSyw/evqZRwH8=","batchProof":"HuWOarlO5AD2gYQA0sV8jlPYenUb857vfqzJ8JIReAKlAt9AkLZlBjfv2sMMvNT17towBiIihGdLEfZfx8v6AQ==","signedTokens":["0pLmwGg5Yc+AorecEZOk4IkAuJI8+HOEQnKkGXCxhx4="]}}
[5941:775:0225/152310.537876:VERBOSE1:confirmations.cc(224)] Successfully redeemed unblinded token with confirmation id afc3664d-44dc-4cdf-9d6c-4862e1717aff, creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690 and landed
[5941:775:0225/152310.538493:VERBOSE1:confirmations.cc(245)] Added 1 unblinded payment token with an estimated redemption value of 0 BAT, you now have 3 unblinded payment tokens

Screen Shot 2021-02-25 at 3 25 51 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants