Focus ring on article's attribution/source slightly obscures its timestamp, above it

[stephendonner]

Description

Focus ring on article's attribution/source slightly obscures timestamp, above it

Steps to Reproduce

This only happens on the smaller articles/items -- not the full-width ones

1. launch Brave with a new profile, using --args --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=6,"*/brave_user_model/*"=6 --brave-ads-development --brave-ads-debug --rewards=development=true,reconcile-interval=5 --brave-today-host=brave-today-cdn.brave.software (or some variants for --brave-ads and --rewards= values)
2. open a new-tab page
3. scroll down to Brave Today's content
4. tab to, click, or hold+click over a smaller article's attribution/source

Actual result:

Look at the size and positioning of the focus ring; it overlaps the timestamp

Expected result:

To be more legible and consistent, it should have additional vertical padding between the source and its loose timestamp

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.21.55 Chromium: 88.0.4324.152 (Official Build) beta (x86_64)
Revision	6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS	macOS Version 11.2.1 (Build 20D74)

Version/Channel Information:

• Can you reproduce this issue with the current release? No
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

[petemill]

There will be some instances of this, since the button size (and therefore padding) grows as the text gets longer, to avoid weirdly small padding when the text is longer. Since the border only shows on hover, we don't want only the space between the publisher name and the date (which, again, changes with the growing text) being a different size on each item. So we put the border and padding on a negative margin. Occasionally this will then appear over the time, but it is an acceptable compromise.

However, it does seem like the spacing has reduced recently on the smaller cards... 🤔

[srirambv]

+1 from @OliverRedman via #16216

[srirambv]

+1 from @aliabe-creator via #19359

[stephendonner]

This issue doesn't reproduce in the redesign, so marking as won'tfix 👍

Brave | 1.62.130 Chromium: 120.0.6099.199 (Official Build) beta (x86_64)
-- | --
Revision | 6d589c6dc0f3489830d40332c82cdd5597e41c88
OS | macOS Version 11.7.10 (Build 20G1427)

example	example	example	example