Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brave Ads panel content and summary in BRewards Settings page #1533

Closed
jenn-rhim opened this issue Oct 11, 2018 · 5 comments
Closed

Add Brave Ads panel content and summary in BRewards Settings page #1533

jenn-rhim opened this issue Oct 11, 2018 · 5 comments

Comments

@jenn-rhim
Copy link

Description

The attached are the finalized Ads container content and the setting. Ads settings current contains only one control - ad notification hourly frequency.

screen shot 2018-10-09 at 11 13 52 pm

screen shot 2018-10-09 at 11 14 04 pm

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (chrome://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
  • Does it reproduce on browser-laptop?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@NejcZdovc NejcZdovc added this to the 0.56.x milestone Oct 11, 2018
@NejcZdovc NejcZdovc modified the milestones: 1.0, 0.57.x - Dev Oct 22, 2018
@bbondy bbondy modified the milestones: 0.57.x - Dev, 1.x Backlog Oct 30, 2018
@NejcZdovc NejcZdovc removed the blocked label Dec 3, 2018
@NejcZdovc NejcZdovc assigned ryanml and unassigned NejcZdovc Dec 3, 2018
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.59.x - Dev Dec 8, 2018
@NejcZdovc
Copy link
Contributor

done in brave/brave-core#999

@LaurenWags
Copy link
Member

@jenn-rhim can you help with a test plan for this one? Unsure what we should be looking at on 0.59.x specifically.

@NejcZdovc
Copy link
Contributor

@LaurenWags for 0.59 there should be only settings page

@btlechowski
Copy link

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Windows 7

Based on #1533 (comment), Ads settings page:
image

@srirambv
Copy link
Contributor

Marking issue as Windows/Mac only as ads is not supported on Linux for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment