Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstoppable Domains IPFS for local gateway should show ipfs:// #15750

Closed
Tracked by #17112
bbondy opened this issue May 11, 2021 · 10 comments · Fixed by brave/brave-core#8912
Closed
Tracked by #17112

Unstoppable Domains IPFS for local gateway should show ipfs:// #15750

bbondy opened this issue May 11, 2021 · 10 comments · Fixed by brave/brave-core#8912
Assignees

Comments

@bbondy
Copy link
Member

bbondy commented May 11, 2021

When Unstoppable Domains is set to resolve via Ethereum, and the local gateway is in use, we resolve to an IPFS URI like:
http://bafybeihihoci7ocqupvuda3ldpiy5zvjctgybg32jxpppplkstdwtq7dhi.ipfs.localhost:48081/

Screen Shot 2021-05-11 at 10 21 19 AM

Instead we should show ipfs:// in that case.

@lidel
Copy link

lidel commented May 11, 2021

How does Ethereum resolution work? If it is using https://resolver.unstoppable.io/dns-query or https://eth.resolver.cloudflare-eth.com/dns-query then we will be able to keep ipns:// when go-ipfs 0.9.0 ships (#15749 (comment))

@yrliou
Copy link
Member

yrliou commented May 11, 2021

@lidel Currently it calls Unstoppable Domains smart contract via eth_call when visiting *.crypto, if there's IPFS content hash record existed, we'll redirect to ipfs://{CID} using that.

@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 14, 2021
@lidel
Copy link

lidel commented May 18, 2021

@yrliou is Brave running own Ethereum light client, or is the eth_call delegated to some infra in the cloud?

@yrliou
Copy link
Member

yrliou commented May 18, 2021

@lidel currently we do eth_call via Infura.

@lidel
Copy link

lidel commented May 22, 2021

Ack. In that case we need to wait for go-ipfs 0.9.0, and we will be able to show ipns://*.crypto

@spylogsster
Copy link

spylogsster commented May 24, 2021

UD set as Ethereum, ipfs as local node:

@lidel
Copy link

lidel commented May 25, 2021

We should start work towards supporting .crypto over DoH resolver in 0.9.0+
UX is better, and you don't decrease security in any way (resolution is delegated to a third party in both cases, but using DoH for name resolution keeps ipns://brad.crypto in address bar.

@spylogsster
Copy link

spylogsster commented May 31, 2021

about the DNS error with 0.7.0, it works fine on another computer and navigates me to ipfs://bafybeihihoci7ocqupvuda3ldpiy5zvjctgybg32jxpppplkstdwtq7dhi/ (brad.crypto + UD set as Ethereum + ipfs as local node) @lidel @bbondy

@lidel
Copy link

lidel commented May 31, 2021

Note that the behavior with 0.7.0 is pointing the user at a static snapshot – the user may not understand this is an immutable version, and if they bookmark ipfs:// URI they will get stuck with this version of the website forever.

@stephendonner
Copy link

Verified PASSED using

Brave 1.27.56 Chromium: 91.0.4472.101 (Official Build) nightly (x86_64)
Revision af52a90bf87030dd1523486a1cd3ae25c5d76c9b-refs/branch-heads/4472@{#1462}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile
  2. loaded ipns://brantly.eth
  3. clicked on Use a local node
  4. set Method to resolve Unstoppable Domains to Ethereum via brave://settings/extensions
  5. loaded brad.crypto
  6. confirmed I was redirected to ipfs://bafybeihihoci7ocqupvuda3ldpiy5zvjctgybg32jxpppplkstdwtq7dhi/
example example example
Screen Shot 2021-06-10 at 9 56 04 AM Screen Shot 2021-06-10 at 9 54 39 AM Screen Shot 2021-06-10 at 9 55 47 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants