Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Brave VPN on Windows #15805

Closed
bsclifton opened this issue May 12, 2021 · 2 comments · Fixed by brave/brave-core#8920
Closed

Implement Brave VPN on Windows #15805

bsclifton opened this issue May 12, 2021 · 2 comments · Fixed by brave/brave-core#8920
Assignees
Labels
feature/vpn feature-request OS/Desktop OS/Windows premium All issues related to Brave Premium priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude

Comments

@bsclifton
Copy link
Member

bsclifton commented May 12, 2021

Description

Part of parent issue #15804

The goal here would be to create an implementation in brave-core which handles VPN on Windows (7, 8, 10). Each OS can provide an OS specific implementation for a "VPN Service".

This would need the ability to:

  • Create a VPN connection with the OS.
  • Update a connection (if details change)
  • Connect to the VPN
  • Disconnect from the VPN
  • Remove the VPN connection from the OS

I've created a proof of concept here which has example Win32 code for viewing and creating entries:
https://github.com/bsclifton/winvpntool/blob/master/main.cpp

We'll want to take this proof of concept and polish it up and add the missing functionality (remove, etc) and put it into the Windows specific implementation for VPN Service in brave-core.

What the user would see in Windows

VPN connections are visible in Windows 10 from:
Settings > Networking & Internet > VPN
image

@simonhong
Copy link
Member

@bsclifton Changed to QA/No because this issue will not cover the UI. So, can't test easily with browser.
When we have UI for premium, I think we could test. WDYT?

@bsclifton
Copy link
Member Author

bsclifton commented May 28, 2021

@simonhong SGTM! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/vpn feature-request OS/Desktop OS/Windows premium All issues related to Brave Premium priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants