Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave News sources list in Customize panel shows 0 when not yet opted-in #15977

Closed
stephendonner opened this issue May 19, 2021 · 4 comments · Fixed by brave/brave-core#9074
Closed

Comments

@stephendonner
Copy link

Description

Brave News sources list in Customize panel shows 0 when not yet opted-in

Steps to Reproduce

  1. new profile, launch Brave
  2. click on Skip welcome tour or open a new-tab page
  3. scroll down
  4. click No thanks to the Brave News opt-in
  5. scroll back up
  6. click on Customize
  7. click on Brave News on the left
  8. now, click to toggle Show Brave News to On
  9. look at the panel

Actual result:

A stray 0 shows up beneath the Show Brave News toggle

Screen Shot 2021-05-19 at 1 12 45 PM

brave-news-zero

Expected result:

Should either disable the toggle control or show the list of sources anyway; I'm not sure

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.26.30 Chromium: 91.0.4472.57 (Official Build) nightly (x86_64)
Revision e3443317fa07f1e9997e4a9c738eddfefc3c0292-refs/branch-heads/4472_54@{#6}
OS macOS Version 11.3.1 (Build 20E241)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? no
  • Can you reproduce this issue with the nightly channel? yes

/cc @petemill @karenkliu

@karenkliu
Copy link

Haha thanks for catching this.

Toggling Brave News on through Customize Dashboard should show the feed. It acts the same as if they clicked on "Show Brave News" in the welcome card.

@stephendonner
Copy link
Author

@rebron can we get this slotted into 1.26.x?

@GeetaSarvadnya
Copy link

Reproduced in Windows 10 x64 - 1.26.74

@stephendonner
Copy link
Author

Verified FIXED using the inline testplan with build

Brave 1.27.62 Chromium: 91.0.4472.101 (Official Build) nightly (x86_64)
Revision af52a90bf87030dd1523486a1cd3ae25c5d76c9b-refs/branch-heads/4472@{#1462}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile, launch Brave
  2. click on Skip welcome tour or open a new-tab page
  3. scroll down
  4. click No thanks to the Brave News opt-in
  5. scroll back up
  6. click on Customize
  7. click on Brave News on the left
  8. now, click to toggle Show Brave News to On
  9. look at the panel

Confirmed the categories were present, and Show Brave News was toggled to On

steps 1-7 step 8
Screen Shot 2021-06-14 at 1 54 23 PM Screen Shot 2021-06-14 at 1 55 10 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants