Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Open using IPFS" icon appears twice for separate URLS from the same flow #16235

Closed
Tracked by #17112
stephendonner opened this issue Jun 3, 2021 · 1 comment · Fixed by brave/brave-core#9035
Closed
Tracked by #17112

Comments

@stephendonner
Copy link

Description

"Open using IPFS" icon appears twice for separate URLS from the same flow

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. load ipns://brantly.eth
  4. click on Use a local node
  5. load https://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq.ipfs.cf-ipfs.com/wiki/Vincent_van_Gogh.html
  6. click on the Open using IPFS icon in the URL bar; you'll land on ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html
  7. now, click on the Open using IPFS icon in the URL bar; you'll land on ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq//bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html

Actual result:

step 5 step 6 step 7
Screen Shot 2021-06-03 at 3 35 08 PM Screen Shot 2021-06-03 at 3 35 11 PM Screen Shot 2021-06-03 at 3 33 43 PM

Expected result:

Note the // in the last URI, there: ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq//bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html

This might be a dupe of one of the recent path-gateway URI-resolving issues (such as #16229), but wanted to make sure it was logged as a separate, verifiable-as-fixed case.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.27.39 Chromium: 91.0.4472.77 (Official Build) nightly (x86_64)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS macOS Version 11.4 (Build 20F71)

/cc @spylogsster @lidel

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.27.57 Chromium: 91.0.4472.101 (Official Build) nightly (x86_64)
Revision af52a90bf87030dd1523486a1cd3ae25c5d76c9b-refs/branch-heads/4472@{#1462}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile
  2. launch Brave
  3. load ipns://brantly.eth
  4. click on Use a local node
  5. load https://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq.ipfs.cf-ipfs.com/wiki/Vincent_van_Gogh.html
  6. click on the Open using IPFS icon in the URL bar; you'll land on ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html
step 5 step 6
Screen Shot 2021-06-10 at 3 31 46 PM Screen Shot 2021-06-10 at 3 32 32 PM

NOTE: Once #16339 lands, I'll retest in that bug, and ensure that the redundant Open using IPFS badge icon isn't present after step 6 is loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants