Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalize Text in Import Selected text to IPFS context-menu item #16421

Closed
stephendonner opened this issue Jun 14, 2021 · 2 comments · Fixed by brave/brave-core#9154
Closed

Comments

@stephendonner
Copy link

stephendonner commented Jun 14, 2021

Description

Capitalize Text in Import Selected text to IPFS context-menu item

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. load ipns://brantly.eth
  4. click on Use a local node
  5. load https://www.lipsum.com/
  6. scroll down to the Lorem ipsum... paragraph, highlight it, and context-click
  7. look at the Import Selected text to IPFS menu item

Actual result:

Menu item reads Import Selected text to IPFS

Screen Shot 2021-06-14 at 4 04 23 PM

Expected result:

Should probably read Import Selected Text to IPFS

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.27.63 Chromium: 91.0.4472.101 (Official Build) nightly (x86_64)
Revision af52a90bf87030dd1523486a1cd3ae25c5d76c9b-refs/branch-heads/4472@{#1462}
OS macOS Version 11.4 (Build 20F71)
@soham4abc
Copy link

I can work in this issue

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.28.18 Chromium: 91.0.4472.114 (Official Build) nightly (x86_64)
Revision 4bb19460e8d88c3446b360b0df8fd991fee49c0b-refs/branch-heads/4472@{#1496}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile
  2. launch Brave
  3. load ipns://brantly.eth
  4. click on Use a local node
  5. load https://www.lipsum.com/
  6. scroll down to the Lorem ipsum... paragraph, highlight it, and context-click
  7. look at the Import Selected text to IPFS menu item

Confirmed the context-menu item now reads Import Selected Text to IPFS

Screen Shot 2021-06-21 at 5 12 32 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment