Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get all regions in desktop vpn service and expose to mojom #17899

Closed
Tracked by #15804
nullhook opened this issue Sep 7, 2021 · 1 comment · Fixed by brave/brave-core#10031
Closed
Tracked by #15804

Get all regions in desktop vpn service and expose to mojom #17899

nullhook opened this issue Sep 7, 2021 · 1 comment · Fixed by brave/brave-core#10031
Assignees
@nullhook
Labels
dev-concern feature/vpn OS/Desktop QA/No release-notes/exclude
Milestone
1.31.x - Release

Comments

@nullhook
Copy link

nullhook commented Sep 7, 2021 •
edited
Loading

The vpn webui needs to render all regions from the backend service and should be able to select a hostname to connect to a different location. This method should be overridden from the mojom service handler.

Currently, it's rendering static location data.
@nullhook nullhook self-assigned this Sep 7, 2021
@bsclifton bsclifton mentioned this issue Sep 7, 2021
Closed
38 tasks
@simonhong simonhong mentioned this issue Sep 10, 2021
Merged
24 tasks
@simonhong
Copy link
Member

Closed as brave/brave-core#10031 fixes this.

@simonhong simonhong added this to the 1.31.x - Nightly milestone Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nullhook nullhook

Labels
dev-concern feature/vpn OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.31.x - Release
Development

Successfully merging a pull request may close this issue.

Fetch and cache region list at startup brave/brave-core
2 participants
@simonhong @nullhook