Upgrade from Chromium 97 to Chromium 98

[mkarolin]

Test plan

• This is a major Chromium version bump, please do full passes.
• For 1.35, see test plan in Upgrade from Chromium 97 to Chromium 98 (uplift to 1.35.x). brave-core#11985

Description

Upgrade from Chromium 97 to Chromium 98.

https://chromium.googlesource.com/chromium/src/+log/97.0.4692.71..98.0.4758.48/?pretty=fuller&n=10000

Desktop Affected areas:

• Settings UI (general check on missing elements)
• Brave News (loads correctly)
• Components updater
• Permissions bubble shows correctly
• Tabs search button toggle in settings works correctly (Win 7, Win 10+, non-Windows)
• AdBlock regional list
• Cosmetic filtering

Android Affected areas:

• Privacy settings
• Night mode (just double check that option works)
• Tabs overview UI
• Top and bottom toolbars UI

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.36.66 Chromium: 98.0.4758.66 (Official Build) nightly (64-bit)
-- | --
Revision | db1b4001d5ce29f141297f260d2b778e000b85a3-refs/branch-heads/4758@{#762}
OS | Windows 10 Version 21H2 (Build 19044.1466)

1. Settings UI:

• Confirmed all the settings are displayed as expected in brave://settings and UI also looks good. Encountered the issue- https://bugs.chromium.org/p/chromium/issues/detail?id=1288911 for missing Autocomplete searches and URLs
• Confirmed content settings are displayed as expected brave://settings/content
• Confirmed security settings are as expected, no new settings are added as part of CR 98 in brave://settings/security
• Confirmed brave://settings/searchEngines is displayed as expected no new settings added, the UI looks good
• Confirmed all the settings under brave://settings/extensions are displayed as expected
• Confirmed Share this page options works as expected
  

2. Brave News

• Confirmed click on Show Brave News shows the brave news feeds
• Confirmed content cards are loading the images correctly in feeds when the brave news feed is scrolled down
• Confirmed click on any image/link on news feed redirects to correct target link
• Confirmed images render properly on brave news feeds when any publisher is enabled/disabled via Sources

3. Components updater

• Testing is covered in Manual test run on Win x64 for 1.36.x - Nightly (Checking C98) #20668 (comment)

4. Permissions bubble shows correctly

• Confirmed site settings permissions work as expected

Example	Example	Example

5. Cosmetic filtering

• Cosmetic filtering works as expected
• Element on any page can be blocked via block element selector

element blocked	blocked rule	remove rules	blocked elements reappeared

6. AdBlock regional list

• Encountered the issue Regional adblock filters are not pre-selected based on locale #4367
• Launched browser using brave.exe --lang=fr and confirmed correct Adblock regional filter is pre-selected in brave://adblok
• Launched browser using brave.exe --lang=de and confirmed correct Adblock regional filter is pre-selected in brave://adblok

Example	Example

7. Tabs search button toggle in settings works correctly

• Confirmed Tab search option is shown when the Show tab search button settings is enabled
• Confirmed able to search the particular tab from list of tabs
• Confirmed Tab search option isn't shown when the Show tab search button settings is disabled
• Confirmed Show tab search button setting retained after browser restart

Example	Example	Example

[srirambv]

Verification passed on Oppo Reno 5 with Android 11 running 1.36.66 x64 nightly build

1. Privacy settings

• Verified privacy settings changes are retained on upgrade
• Verified none of the privacy settings are removed/updated defaults on a clean install

2. Night mode

• Verified night mode works fine
• Verified night mode setting is retained on upgrade
• Encountered Crash after setting Night theme to on #20673 but not consistently reproducible

3. Tabs overview UI

• Verified tabs overview UI works fine
• Verified no crash when loading tabs overview UI
• Verified able to group tabs when settings is enabled via tabs overview
• Verified able to scroll through tabs list when tab groups setting is disabled

4. Top and bottom toolbars UI

• Verified bottom toolbar UI works fine
• Verified disable bottom toolbar prompts for restart and after restarts only shows the top UI
• Verified buttons on bottom toolbar works as expected
• Verified long press context menus work on bottom toolbar buttons as expected

In addition #20669 was also verified and verification notes can be found here #20669 (comment)

[kjozwiak]

@brave/legacy_qa there's two SKU cases mentioned via brave/brave-core#11985 (comment) that we'll need to run through with 1.35.x to make sure that the SKU PR that was part of brave/brave-core#11985 didn't cause any issues. All of the SKU/VPN work should be behind a flag.

On Android, we'll need to remotely use DevTools to run through the cases @bsclifton added 👍

[kjozwiak]

Labelling as QA/No in favour of #20726.