Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN status doesn't show the connected state when brave is auto-upgraded #23080

Closed
GeetaSarvadnya opened this issue May 26, 2022 · 2 comments · Fixed by brave/brave-core#13505
Closed

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 26, 2022

Description

VPN status doesn't show connected state when brave is auto-upgraded from 1.40.68 to 1.40.75

Steps to Reproduce

  1. Clean profile 1.40.68
  2. Follow the steps to connect VPN
  3. Make sure VPN is connected
  4. Open brave://settings/help wait for the update and click on Relaunch
  5. After upgrading to 1.40.75 VPN status doesn't show the connected state also encountered Brave VPN from hamburger menu doesn't always show available sub menu #22726

Actual result:

VPN status doesn't show the connected state when brave is auto-upgraded from 1.40.68 to 1.40.75

1.40.68 1.40.75
image image

Expected result:

VPN status should show the connected state when brave is auto-upgraded from 1.40.68 to 1.40.75

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.40.75 Chromium: 102.0.5005.61 (Official Build) beta (64-bit)
Revision 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS Windows 10 Version 21H2 (Build 19044.1706)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Not sure

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @simonhong @bsclifton @spylogsster @brave/qa-team

@simonhong simonhong self-assigned this May 27, 2022
simonhong added a commit to brave/brave-core that referenced this issue May 27, 2022
Connection state is queried when purchased state is loaded and
it's purchased user.

fix brave/brave-browser#22677
fix brave/brave-browser#22726
fix brave/brave-browser#23080
simonhong added a commit to brave/brave-core that referenced this issue May 30, 2022
Connection state is queried when purchased state is loaded and
it's purchased user.

fix brave/brave-browser#22677
fix brave/brave-browser#22726
fix brave/brave-browser#23080
@simonhong simonhong added this to the 1.41.x - Nightly milestone Jun 2, 2022
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Jun 9, 2022

Verification PASSED on


Brave | 1.41.39 Chromium: 102.0.5005.78 (Official Build) nightly (64-bit)
-- | --
Revision | df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS | Windows 10 Version 21H2 (Build 19044.1706)

  • Verified the STR from the description and ensured the following:
    • Confirmed VPN status is connected in an upgraded profile
    • Confirmed VPN connected status is retained after the browser restart
    • Confirmed VPN can be connected to other regions and status stays connected after the browser restart
1.41.34 1.41.39
image image

@stephendonner
Copy link

Verified PASSED using

Brave 1.41.55 Chromium: 102.0.5005.115 (Official Build) nightly (x86_64)
Revision 174dbe6e33bc81994fceb71d751be201d0b4803d-refs/branch-heads/5005_109@{#3}
OS macOS Version 12.5 (Build 21G5037d)

Steps:

  1. installed 1.41.49
  2. launched Brave
  3. set up VPN via dev (account.brave.software)
  4. ensured I connected to USA (West) region successfully
  5. opened brave://settings/help and confirmed it found an update
  6. clicked on Restart to restart the browser
  7. confirmed VPN was still connected
1.41.49 1.41.55
Screen Shot 2022-06-11 at 12 52 29 AM Screen Shot 2022-06-11 at 12 52 45 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment