Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text duplicated on manage wallet screen #2446

Closed
srirambv opened this issue Dec 11, 2018 · 11 comments
Closed

Text duplicated on manage wallet screen #2446

srirambv opened this issue Dec 11, 2018 · 11 comments

Comments

@srirambv
Copy link
Contributor

Description

Text duplicated on manage wallet screen

Steps to Reproduce

  1. Clean profile on 0.58.11
  2. Enable rewards by clicking on BR button in URL bar
  3. Click on Advanced options. The info text is duplicated (see screenshot)

Actual result:

image

Expected result:

Should not duplicate the info text

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@brave/legacy_qa to verify on other platforms

@LaurenWags
Copy link
Member

Does not reproduce for me on macOS

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

screen shot 2018-12-11 at 10 24 02 am

@rebron rebron added OS/Windows priority/P3 The next thing for us to work on. It'll ride the trains. labels Dec 11, 2018
@simonhong
Copy link
Member

Hmm, I can't reproduce on all platform with current master.

@btlechowski
Copy link

Not reproducible on Windows

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows 7 x64

image

@rebron
Copy link
Collaborator

rebron commented Dec 12, 2018

@simonhong looks like it's related to #2481, only affects Linux. Maybe combine fix for both.

@simonhong
Copy link
Member

simonhong commented Dec 13, 2018

@srirambv Can you re-install latest version and check again?
brave/brave-core#909 fixes this and it is merged into 0.58.x and 0.59.x.
I newly installed beta/dev version on linux(ubuntu) and I can't see duplicated strings.

@rebron
Copy link
Collaborator

rebron commented Dec 18, 2018

@NejcZdovc any idea on this one? Would like a fix for 58.x but can move out if we can't get a fix in time.

@kjozwiak
Copy link
Member

@srirambv Can you re-install latest version and check again?
brave/brave-core#909 fixes this and it is merged into 0.58.x and 0.59.x.
I newly installed beta/dev version on linux(ubuntu) and I can't see duplicated strings.

Still appears to be broken under Ubuntu 18.04.1 x64 using the following build:

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Linux

screen shot 2018-12-18 at 1 12 26 am

screen shot 2018-12-18 at 1 12 33 am

@bbondy bbondy modified the milestones: 0.58.x - Release, 1.x Backlog Dec 18, 2018
@bbondy
Copy link
Member

bbondy commented Dec 18, 2018

Please use project boards to indicate priority, we only use milestones for tracking closed issues.

@btlechowski
Copy link

btlechowski commented Dec 18, 2018

Does not reproduce on Ubuntu 17.10 VM. I use VirtualBox.

image

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Linux

@kjozwiak kjozwiak added needs-investigation A bug not 100% confirmed/fixed and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Dec 18, 2018
@kjozwiak
Copy link
Member

kjozwiak commented Dec 18, 2018

Removing P3 and adding the needs-investigation. Both @NejcZdovc & @btlechowski can't reproduce the issues on their VM's but @srirambv and myself can. We need to figure out what the difference is any why some users are seeing the above and some aren't.

I did a quick Zoom call with @NejcZdovc and he was using the same Ubuntu version but couldn't reproduce the issue. Maybe some type of dependency issue? I tried it on my Mint laptop and I could reproduce the same issue even though the deb installer told me all dependencies were installed.

We need more information.

@kjozwiak
Copy link
Member

kjozwiak commented Jan 29, 2019

Closing the issue as it looks resolved with 0.59.31 Chromium: 72.0.3626.71. @srirambv also mentioned under #3131 (comment) that it was fixed for him as well. Went through the following:

  • Mint 19.1 x64 VM - Couldn't reproduce the issue
  • Mint 19.1 x64 (physical machine) - Couldn't reproduce the issue
  • Ubuntu 18.04 x64 VM - Couldn't reproduce the issue

screen shot 2019-01-29 at 5 52 36 pm

screen shot 2019-01-29 at 5 52 44 pm

Used the following build:

Brave 0.59.31 Chromium: 72.0.3626.71 (Official Build) (64-bit)
Revision f52ccad2a6a3c65fc9e0c591a517ceab1198dac0-refs/branch-heads/3626@{#763}

@brave/legacy_qa if you see the issue again, please re-open 👍

@kjozwiak kjozwiak modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Jan 29, 2019
@rebron rebron removed this from the Dupe / Invalid / Not actionable milestone May 10, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants