Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misaligned UI elements on view sync code modal #2546

Closed
btlechowski opened this issue Dec 13, 2018 · 4 comments · Fixed by brave/brave-core#1093
Closed

Misaligned UI elements on view sync code modal #2546

btlechowski opened this issue Dec 13, 2018 · 4 comments · Fixed by brave/brave-core#1093

Comments

@btlechowski
Copy link

Steps to Reproduce

  1. Sync two devices
  2. In Desktop Browser click view sync code

Actual result:

Misaligned UI elements

image

Expected result:

The UI elements are properly aligned

Brave version (brave://version info)

Brave 0.58.12 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows 7

cc @brave/legacy_qa

@kjozwiak
Copy link
Member

Lets try getting this fixed in 0.58.x if possible as it looks pretty bad... Doesn't look professional and users will question if we even noticed something that obvious as the above.

@rebron
Copy link
Collaborator

rebron commented Dec 13, 2018

@petemill @cezaraugusto can you guys take a look at this one?

@cezaraugusto cezaraugusto self-assigned this Dec 13, 2018
@bradleyrichter
Copy link

We can't ship this as is. Must fix please.

@btlechowski
Copy link
Author

btlechowski commented Dec 17, 2018

Verification passed on

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows 7

Looks better
image

Padding between Word Code and QR Code could be improved. Reported #2591

Verified passed with

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Mac OS X
  • Verified STR from description.

Verification PASSED on Ubuntu 18.04.1 x64 using the following build:

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Linux

screen shot 2018-12-17 at 10 22 49 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment