Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable sync by default in 0.58.x #2609

Closed
darkdh opened this issue Dec 17, 2018 · 6 comments
Closed

Disable sync by default in 0.58.x #2609

darkdh opened this issue Dec 17, 2018 · 6 comments
Assignees
@darkdh
Labels
feature/sync QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.58.x - Release ...

Comments

@darkdh
Copy link
Member

darkdh commented Dec 17, 2018

In order to use sync, use --enable-brave-sync switch
@darkdh darkdh added this to the 0.58.x - Release milestone Dec 17, 2018
@darkdh darkdh self-assigned this Dec 17, 2018
@darkdh darkdh mentioned this issue Dec 17, 2018
Merged
18 tasks
@darkdh
Copy link
Member Author

darkdh commented Dec 17, 2018

closed by brave/brave-core#1116

@darkdh darkdh closed this as completed Dec 17, 2018
@LaurenWags
Copy link
Member

LaurenWags commented Dec 19, 2018 •
edited
Loading

@darkdh with the below version Sync is still available on Settings page, is this expected? fwiw, navigating to brave://sync results in an error.

Brave 0.58.15 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Mac OS X

screen shot 2018-12-19 at 10 46 59 am

screen shot 2018-12-19 at 10 46 43 am

Also, Sync is not available in hamburger menu (as I would expect):
screen shot 2018-12-19 at 10 46 04 am

cc @kjozwiak @rebron

@btlechowski
Copy link

btlechowski commented Dec 19, 2018 •
edited
Loading

@LaurenWags Also reproduced on Windows 7.

Brave 0.58.15 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows 7

image

@kjozwiak
Copy link
Member

Seeing the same thing with macOS 10.14.2 x64 and Windows 10 x64 using the following build:

Brave 0.58.15 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}

@LaurenWags LaurenWags mentioned this issue Dec 19, 2018
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Dec 19, 2018 •
edited by btlechowski
Loading

Verified passed with

Brave 0.58.15 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Mac OS X
  • Verified Sync is not available from hamburger menu
  • Verified navigating to brave://sync results in an error
  • Sync is still available in Settings, logged follow up issue Sync available in Settings - follow up to 2609 #2642
  • Verified launching with the --enable-brave-sync flag on macOS showed Sync in hamburger menu, and no error was displayed when navigating to brave://sync. Also verified could sync with Android 1.0.71 (sync3).

Verification PASSED on Ubuntu 18.04.1 x64 using the following build:

Brave 0.58.15 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Linux
  • Verified Sync is not available from hamburger menu
  • Verified navigating to brave://sync results in an error
  • Sync is still available in Settings, logged follow up issue Sync available in Settings - follow up to 2609 #2642
  • Verified launching with the --enable-brave-sync flag on Ubuntu 18.04.1 x64 showed Sync in hamburger menu, and no error was displayed when navigating to brave://sync. Also verified could sync with a Win 10 x64 machine running 0.58.15

Verification PASSED on Windows 10 x64 using the following build:

Brave 0.58.15 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows
  • Verified Sync is not available from hamburger menu
  • Verified navigating to brave://sync results in an error
  • Sync is still available in Settings, logged follow up issue Sync available in Settings - follow up to 2609 #2642
  • Verified launching with the --enable-brave-sync flag on Windows 10 x64 showed Sync in hamburger menu, and no error was displayed when navigating to brave://sync. Also verified could sync with a Ubuntu 18.04.1 x64 machine running 0.58.15

Verification passed on

Brave 0.58.15 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows 7
  • Verified Sync is not available from hamburger menu
  • Verified navigating to brave://sync results in an error
  • Sync is still available in Settings, logged follow up issue Sync available in Settings - follow up to 2609 #2642
  • Verified launching with the --enable-brave-sync flag on
  • Brave Sync is shown in hamburger menu and opens brave://sync
  • brave://sync opens Sync page
  • could sync with Android 1.0.71 (sync3).

@darkdh
Copy link
Member Author

darkdh commented Dec 19, 2018

fixed in brave/brave-core#1146

@kjozwiak kjozwiak mentioned this issue Jan 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkdh darkdh

Labels
feature/sync QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.58.x - Release (Release Channel)
Development

No branches or pull requests
4 participants
@kjozwiak @darkdh @LaurenWags @btlechowski