Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign Copy keyboard shortcut to "copy clean link" #26761

Closed
fmarier opened this issue Nov 14, 2022 · 5 comments · Fixed by brave/brave-core#16764
Closed

Assign Copy keyboard shortcut to "copy clean link" #26761

fmarier opened this issue Nov 14, 2022 · 5 comments · Fixed by brave/brave-core#16764

Comments

@fmarier
Copy link
Member

fmarier commented Nov 14, 2022

Users have been asking for "copy clean URLs" to be the default so that they don't have to remember to use it when copying from the URL bar.

We should change the keyboard shortcut:
copy-shortcut

@spylogsster
Copy link

For Mac App menu part created another issue #27902

@spylogsster spylogsster added this to the 1.49.x - Nightly milestone Jan 25, 2023
@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 13, 2023
@stephendonner
Copy link

stephendonner commented Feb 13, 2023

Verified PASSED using

Brave 1.49.96 Chromium: 110.0.5481.77 (Official Build) beta (x86_64)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS macOS Version 11.7.3 (Build 20G1116)

Case 1: Copy Clean Link - PASSED

  1. installed 1.49.96
  2. launched Brave
  3. loaded https://twitter.com/fmarier/status/1574869891978784769?s=21&t=lkfjeslkfjes&fbclid=1234
  4. selected the URL
  5. pressed command +C to copy
  6. pressed command + V to paste

Confirmed Copy Clean Link was used, as the pasted URL is https://twitter.com/fmarier/status/1574869891978784769?fbclid=1234 (removed s=21, and t=lkf... params)

Copy Clean Link shortcut command + C used command + v
Screen Shot 2023-02-13 at 3 31 28 PM Screen Shot 2023-02-13 at 3 22 20 PM

Case 2: Copy text - PASSED

  1. new profile
  2. launched Brave
  3. loaded https://twitter.com/fmarier/status/1574869891978784769?s=21&t=lkfjeslkfjes&fbclid=1234
  4. selected a random substring of text from the URL /157486989197878476
  5. pressed command + C to copy
  6. pressed command + V to paste

Confirmed regular copy and paste operations for non-URL text pasted /157486989197878476

Copy shortcut command + C used command + V
Screen Shot 2023-02-13 at 3 35 06 PM Screen Shot 2023-02-13 at 3 35 17 PM

@MadhaviSeelam
Copy link

MadhaviSeelam commented Feb 21, 2023

Verification PASSED using

Brave | 1.49.106 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
-- | --
Revision | 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS | Windows 11 Version 21H2 (Build 22000.1574)

Case 1: Copy Clean Link - PASSED

  1. installed 1.49.106
  2. launched Brave
  3. loaded https://twitter.com/fmarier/status/1574869891978784769?s=21&t=lkfjeslkfjes&fbclid=1234
  4. selected the URL
  5. pressed command +C to copy
  6. pressed command + V to paste

Confirmed Copy Clean Link was used, as the pasted URL is https://twitter.com/fmarier/status/1574869891978784769?fbclid=1234 (removed s=21, and t=lkf... params)

Copy Clean Link shortcut command + C used command + v
image image

Case 2: Copy item from context menu should copy selected url without changes - PASSED

  1. new profile
  2. launched Brave
  3. loaded https://twitter.com/fmarier/status/1574869891978784769?s=21&t=lkfjeslkfjes&fbclid=1234
  4. selected the URL
  5. select Copy from context menu
  6. pressed command + V to paste

Confirmed selected url is pasted without any changes or strip any parameters in the URL `https://twitter.com/fmarier/status/1574869891978784769?s=21&t=lkfjeslkfjes'

Copy from context menu Paste from context menu
image image

Case 3: Copy text - PASSED

  1. new profile
  2. launched Brave
  3. loaded https://twitter.com/fmarier/status/1574869891978784769?s=21&t=lkfjeslkfjes&fbclid=1234
  4. selected a random substring of text from the URL /157486989197878476
  5. pressed command + C to copy
  6. pressed command + V to paste

Confirmed regular copy and paste operations for non-URL text pasted /157486989197878476

Copy shortcut command + C used command + V
image image

Case 4: Copy clean link should not be visible for selected text- PASSED

  1. new profile
  2. launched Brave
  3. loaded https://twitter.com/fmarier/status/1574869891978784769?s=21&t=lkfjeslkfjes&fbclid=1234
  4. selected a random substring of text from the URL /157486989197878476
  5. right click to open context menu

Confirmed context menu shows default hotkey Ctrl+c for Copy item and no Copy clean link is available for non-URL text pasted /157486989197878476

image

@btlechowski btlechowski added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 3, 2023
@btlechowski
Copy link

btlechowski commented Mar 3, 2023

Verification passed on

Brave 1.49.118 Chromium: 111.0.5563.50 (Official Build) (64-bit)
Revision 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS Ubuntu 18.04 LTS

Case 1: Copy Clean Link - PASSED

  1. installed 1.49.x
  2. launched Brave
  3. loaded https://twitter.com/fmarier/status/1574869891978784769?s=21&t=lkfjeslkfjes&fbclid=1234
  4. selected the URL
  5. pressed control +C to copy
  6. pressed control + V to paste

Confirmed Copy Clean Link was used, as the pasted URL is https://twitter.com/fmarier/status/1574869891978784769?fbclid=1234 (removed s=21, and t=lkf... params)

Copy Clean Link shortcut control + C used control + v
image image

Case 2: Copy item from context menu should copy selected url without changes - PASSED

  1. new profile
  2. launched Brave
  3. loaded https://twitter.com/fmarier/status/1574869891978784769?s=21&t=lkfjeslkfjes&fbclid=1234
  4. selected the URL
  5. select Copy from context menu
  6. pressed control + V to paste

Confirmed selected url is pasted without any changes or strip any parameters in the URL `https://twitter.com/fmarier/status/1574869891978784769?s=21&t=lkfjeslkfjes'

Copy from context menu Paste from context menu
image image

Case 3: Copy text - PASSED

  1. new profile
  2. launched Brave
  3. loaded https://twitter.com/fmarier/status/1574869891978784769?s=21&t=lkfjeslkfjes&fbclid=1234
  4. selected a random substring of text from the URL /157486989197878476
  5. pressed control + C to copy
  6. pressed control + V to paste

Confirmed regular copy and paste operations for non-URL text pasted /157486989197878476

Copy shortcut control + C used control + V
image image

Case 4: Copy clean link should not be visible for selected text- PASSED

  1. new profile
  2. launched Brave
  3. loaded https://twitter.com/fmarier/status/1574869891978784769?s=21&t=lkfjeslkfjes&fbclid=1234
  4. selected a random substring of text from the URL /157486989197878476
  5. right click to open context menu

Confirmed context menu shows default hotkey Ctrl+c for Copy item and no Copy clean link is available for non-URL text pasted /157486989197878476

image

Case 5: Copy clean link is assigned to control+c in context menu - FAILED

  1. new profile
  2. launched Brave
  3. loaded https://twitter.com/fmarier/status/1574869891978784769?s=21&t=lkfjeslkfjes&fbclid=1234
  4. selected the whole URL
  5. right click to open context menu

Visually the shortcut is not assigned on Linux. Logged #28891
image

@btlechowski btlechowski added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 3, 2023
@dinhanhthi
Copy link

In the version 1.56.14, I cannot use cmd+C to copy the URL / selection on the address bar. Every time I use cmd+C, it opens the Inspect Element panel. It's annoying!!! The older version doesn't have this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment