Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a device to sync chain doesn't enable sync on Linux instantly #2782

Closed
srirambv opened this issue Jan 2, 2019 · 4 comments
Closed

Comments

@srirambv
Copy link
Contributor

srirambv commented Jan 2, 2019

Description

Adding a device to sync chain doesn't enable sync on Linux instantly. Goes back to the Sync welcome screen. Leaving the page open for a min then shows the device details

Devices

Sync chain creator: 0.59.14 on Ubuntu
Sync chain device2: Samsung Tab running 1.0.72(sync1)

Steps to Reproduce

  1. Clean profile on 0.59.14
  2. Enable Sync from hamburger menu
  3. Add a Mobile device on sync creation process
  4. Scan the QR code on the mobile device, wait for the sync chain to be created. Android device shows Linux desktop as listed device but sync doesn't enable on Linux desktop
  5. Click ok to close the modal on desktop, Device is removed from the list
  6. Open brave://sync in a new tab, wait for ~1 min, sync is enabled on Linux

Actual result:

image
image

Expected result:

Should enable sync instantly when a second device is added to the sync chain

Reproduces how often:

Easy, Was able to reproduce the issue 4 times

Brave version (brave://version info)

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes on beta

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
    N/A
  • Is the issue reproducible on the latest version of Chrome?
    N/A

Additional Information

cc: @brave/legacy_qa @rebron

@srirambv srirambv added bug feature/sync priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude labels Jan 2, 2019
@srirambv srirambv added this to the 1.x Backlog milestone Jan 2, 2019
@AlexeyBarabash
Copy link
Contributor

brave/brave-core#1188 should fix the issue.

@srirambv
Copy link
Contributor Author

@AlexeyBarabash what is the expected time duration with the fix? I see its take around 8secs on my machine to list the sync page. Is this expected time or should it be faster?

@srirambv
Copy link
Contributor Author

Verification passed on based on #2742 (comment)

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta(64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Linux

@AlexeyBarabash
Copy link
Contributor

@srirambv the expected time duration 1 sec to fetch + <delay for over network data transfer netween device2=>AWS=>device2>. The second part of the amount hard to estimate. I observed < 2 sec. Just in case I wrote in issue 5 sec. 8 sec seems ok, as it is much faster then before the PR.

Thanks @srirambv .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants