Looking for device button is missing when QR code is shown

[srirambv]

Test plan

See brave/brave-core#1193

Description

Looking for device button is missing when QR code is shown

Steps to Reproduce

Scenario 1 when its not showing the Loading devices button

1. Create a new profile on 0.59.14
2. Visit brave://sync and click on Start a new sync chain
3. Click on Phone/Tablet, there is no Loading devices button shown (first screenshot gif)
4. Click on Computer, shows code words and shows Loading devices button

Scenario 2 when it shows Loading devices button

1. Create a new profile on 0.59.14
2. Create a sync chain and add a second device to the chain
3. Leave sync chain so that sync is reset on desktop
4. Click on Start a new sync chain again
5. Click on Phone/Tablet, there is no QR code generated and OK button is replaced with Loading devices button shown (second screenshot gif)
6. Click on Computer, no code words are shown but still Loading devices button

Actual result:

See above screencaps

Expected result:

Loading devices button should be shown on both Phone/Computer options

Reproduces how often:

Easy

Brave version (brave://version info)

Brave	0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision	997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS	Linux

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?
  Yes on beta

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
  N/A
• Is the issue reproducible on the latest version of Chrome?
  N/A

Additional Information

cc: @cezaraugusto @rebron @brave/legacy_qa to try on other platforms
cc: @bbondy marking it for 0.59.x as this is a bad problem if sync gets reset on a profile and need to reenable it

[kjozwiak]

Reproduced on macOS 10.14.2 x64 using the following build:

Brave	0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision	997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS	Mac OS X

Moved the issue into the 1.x Backlog as this isn't a release blocker as per our policy. However, as sync is being planned for 0.59.x, we should probably fix this for 0.58.x.

@cezaraugusto rather than waiting for the triage meeting, can you take a look at this?

[btlechowski]

Reproduced on

Brave	0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision	997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS	Windows 7

[GeetaSarvadnya]

Reproducible on

Brave	0.59.14 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision	997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS	Windows 10

[srirambv]

Verification passed on

Brave	0.59.20 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision	997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS	Linux

Verification passed on

Brave	0.59.20 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision	997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS	Windows 10

Verification PASSED on macOS 10.14.2 x64 using the following build:

Brave	0.59.20 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision	997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS	Mac OS X