Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Sync Chain QR Code dialog text #2886

Closed
rebron opened this issue Jan 9, 2019 · 1 comment
Closed

update Sync Chain QR Code dialog text #2886

rebron opened this issue Jan 9, 2019 · 1 comment

Comments

@rebron
Copy link
Collaborator

rebron commented Jan 9, 2019

Description

screen shot 2019-01-09 at 2 53 40 pm

Replace: On your mobile device, navigate to Brave Sync in the Settings panel and click the button "Scan Sync code" Use your camera to scan the QR Code below.

With: "On your mobile device, navigate to Brave Sync in the Settings panel and click the button "Scan or enter sync code". Use your camera to scan the QR Code below."

If adding "or enter" bumps text to a third line, can skip this edit change and can keep "Scan Sync code"

Note the missing period in between sentences. Make sure to add with the corrected text.

@btlechowski
Copy link

btlechowski commented Jan 18, 2019

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Windows 7

Verified the dialog in Start a New Sync Chain, View Sync Code, and Add New Device

image

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Linux

image

Verified with

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta(64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Mac OS X

screen shot 2019-01-18 at 11 05 16 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants