Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant notification displays incorrect text #2945

Closed
LaurenWags opened this issue Jan 14, 2019 · 3 comments · Fixed by brave/brave-core#1402
Closed

Grant notification displays incorrect text #2945

LaurenWags opened this issue Jan 14, 2019 · 3 comments · Fixed by brave/brave-core#1402

Comments

@LaurenWags
Copy link
Member

Description

Grant notification displays incorrect text on Dev. It says Token Grants Claimed but this is the notification to let you know that a grant exists, you haven't claimed anything yet. (note, the rest of the text says "You have a grant waiting for you" which also indicates nothing has been claimed yet)

Steps to Reproduce

  1. Install 0.60.12
  2. Enable Rewards
  3. Look at notification for grant

Actual result:

See first line of notification
screen shot 2019-01-14 at 9 11 16 am

Expected result:

This is what displays in release and Beta versions currently
screen shot 2019-01-14 at 9 15 08 am

Reproduces how often:

Brave version (brave://version info)

Brave 0.60.12 Chromium: 72.0.3626.53 (Official Build) dev(64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? only reproduces on Dev currently

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

@btlechowski
Copy link

Reproduced on Windows 7

image

Brave 0.60.13 Chromium: 72.0.3626.53 (Official Build) dev (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Windows 7

@NejcZdovc NejcZdovc added the needs-investigation A bug not 100% confirmed/fixed label Jan 19, 2019
@NejcZdovc
Copy link
Contributor

I can't reproduce this on source

@NejcZdovc NejcZdovc self-assigned this Jan 21, 2019
@NejcZdovc NejcZdovc added priority/P2 A bad problem. We might uplift this to the next planned release. and removed needs-investigation A bug not 100% confirmed/fixed labels Jan 21, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 21, 2019
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.60.x - Dev Jan 21, 2019
@LaurenWags
Copy link
Member Author

LaurenWags commented Feb 5, 2019

Verified passed with

Brave 0.60.19 Chromium: 72.0.3626.81 (Official Build) beta(64-bit)
Revision ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS Mac OS X

screen shot 2019-02-05 at 3 21 36 pm

Verification passed on

Brave 0.60.23 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Windows 10

BR Panel message - Staging environment

image

Enable rewards through Hamburger menu, click on BAT logo - Staging environment

image

Verification passed on

Brave 0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Linux

Used test plan from brave/brave-core#1402

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants