adsPerDay is too small

[btlechowski]

Steps to Reproduce

1. Run brave with logging
2. Enable rewards and ads

Actual result:

"adsPerDay":6
The limit is too small and may give unexpected behavior when it comes to displaying ad notifications.
Especially, when adsPerHour is set to 5.

[12124:5356:0116/003010.448:INFO:ads_service_impl.cc(946)] AdsService Event Log: {"data":"type":"settings","stamp":"2019-01-16T00:30:10Z","settings":{"notifications":"available":true},"locale":"en","adsPerDay":6,"adsPerHour":2}}

Expected result:

In the UI we only have access to adsPerHour, so user would expect that this is the only limit.
Therefor, temporarily set adsPerDay limit so that it is never triggered.

Reproduces how often:

always

Brave version (brave://version info)

Brave	0.60.13 Chromium: 72.0.3626.53 (Official Build) dev (64-bit)
Revision	98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS	Windows 7

cc @mrose17 @brave/legacy_qa

[mrose17]

Good catch!

[mrose17]

Fixed by brave-intl/bat-native-ads#106

[srirambv]

@mrose17 could you please add the issue to correct milestone as the fixed PR doesn't have a milestone assigned

[kjozwiak]

@mrose17 which channel/version of Brave did this land into? Looks like brave-intl/bat-native-ads#106 was merged into master ~25 days ago. Assuming 0.61.x as master would have been 0.61.x around that time frame?

[mrose17]

find the code in ads_impl.cc that says

/*
  TBD: [MTR] LEAVE UNTIL DESIGN/PRODUCT RESOLVES THE USE OF THIS FEATURE
 */

and then find out when that revision got included in brave-browser. @tmancey may be able to help.