Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twitch verified pubs name is empty in Thank you - Rewards Banner #3265

Closed
GeetaSarvadnya opened this issue Feb 7, 2019 · 5 comments
Closed
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@GeetaSarvadnya
Copy link

Description

twitch verified pubs name is empty in Thank you - Rewards Banner

Steps to Reproduce

  1. Clean profile 0.60.19
  2. Open any verified twitch pubs and tip it (https://www.twitch.tv/videos/226907251)
  3. After tip, pubs name is empty in Thank you - Rewards banner

Actual result:

image

pubs name is empty on rewards banner

Expected result:

Thank you -Rewards banner should have pubs name

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.60.19 Chromium: 72.0.3626.81 (Official Build) beta (64-bit)
Revision ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS Windows

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? na
  • Is the issue reproducible on the latest version of Chrome? na

Additional Information

@brave/legacy_qa @NejcZdovc

@kjozwiak
Copy link
Member

kjozwiak commented Feb 7, 2019

@GeetaSarvadnya are you referring to the empty circle that you're seeing? Should have something similar to the following correct?

screen shot 2019-02-07 at 6 00 18 pm

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Feb 8, 2019

@kjozwiak Yes, that's correct. I was refererring empty circle.

@GeetaSarvadnya GeetaSarvadnya added the priority/P4 Planned work. We expect to get to it "soon". label Feb 8, 2019
@NejcZdovc
Copy link
Contributor

closing as dupe of this one #3273 as the root problem is the same

cc @kjozwiak @rebron if we want this in 0.60

@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Feb 8, 2019
@NejcZdovc NejcZdovc added closed/duplicate Issue has already been reported and removed QA/Yes priority/P4 Planned work. We expect to get to it "soon". labels Feb 8, 2019
@GeetaSarvadnya
Copy link
Author

@NejcZdovc I am seeing this issue for YT verified pubs even, do you think #3273 is the root cause for this as well?
3265

@LaurenWags
Copy link
Member

I can reproduce this but only with a VOD. A live stream shows the correct letter in thank you banner.

Brave 0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Development

No branches or pull requests

5 participants