Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards ON/OFF state doesn't toggle Ads switch to ON/OFF, when rewards is opened in multiple tabs #3309

Closed
GeetaSarvadnya opened this issue Feb 11, 2019 · 2 comments · Fixed by brave/brave-core#1888

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 11, 2019

Description

Found while testing #2961
Rewards ON/OFF state doesn't toggle Ads switch to ON/OFF, when rewards is opened in multiple tabs

Steps to Reproduce

  1. Open brave 0.60.25
  2. Enable Rewards through rewards panel
  3. Turn OFF Rewards switch
  4. Click on BAT logo, click on Settings link which is displayed under Brave Rewards is Off popup
    (Rewards page opened in 2nd tab)
  5. Turn ON Rewards in 2nd rewards tab.
  6. Verify that Ads switch is still in OFF state in 2nd rewards tab

Note: Reload the rewards page, resolve the issue

Actual result:

Rewards ON/OFF state doesn't change Ads switch to ON/OFF, when rewards is opened in multiple tabs

3309

Expected result:

Rewards ON/OFF state should change Ads switch to ON/OFF without page refresh.

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.60.25 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Windows 10

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? na
  • Is the issue reproducible on the latest version of Chrome? na

Additional Information

@brave/legacy_qa @NejcZdovc

@LaurenWags
Copy link
Member

Reproduced on macOS

Brave 0.60.23 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Mar 13, 2019

Verification passed on

Brave 0.63.5 Chromium: 73.0.3683.67 (Official Build) dev (64-bit)
Revision a83fd4f3207ae83412d329a9ca1239dd1e068345-refs/branch-heads/3683@{#760}
OS Windows 10 OS Build 17134.523

Verification passed on

Brave 0.63.14 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux

Verified passed with

Brave 0.63.14 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants