sometimes wrong twitch publisher info is shown including verified logo/text

[LaurenWags]

Description

Sometimes Brave Rewards Panel will show incorrect twitch publisher info, this is particularly bad because the panel will sometimes show the wrong publisher as verified, which is misleading.

Steps to Reproduce

1. Clean profile
2. Launch Brave, enable Rewards
3. Open a tab and navigate to twitch.tv/directory
4. Click on a subject like Fortnite
5. Click on a name (not stream) of one of the people in this category (this will take you to their videos page, not their current live stream)
6. Click on a Video to start playing a VOD for this publisher who we’re going to call pub1.
7. Click on the panel (chances are they’re not a verified publisher).
8. Click on search box, type in neoness007, click on this person under the 'Channels' heading in the drop down search results box.
9. Once stream starts (wait until after pre-roll ad if one shows), click on BAT logo.

Actual result:

10. Info for previous publisher (pub1) is shown and incorrect publisher is shown as verified with custom favicon but in fact, you're on a different publisher page. Note - the person who's page you are on is actually verified, not pub1.
    
    For reference, this is what I see when I access the Brave Rewards panel while on pub1's channel:
    

Additionally, if you do try to tip while seeing the wrong info in panel, you incorrectly see pub1 info on the tip banner. If you tip them, they’re listed in the tips table on brave://rewards

Now if you go to brave://rewards, a-c table shows pub1 listed twice - once as verified and once as not verified.

Expected result:

Incorrect info shouldn't be shown anywhere - panel, a-c table, tip banner, tips table.

Reproduces how often:

consistently with steps above

Brave version (brave://version info)

Brave	0.60.44 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision	fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS	Mac OS X

Reproducible on current release: n/a - 0.59.35 doesn't have twitch tipping

• Does it reproduce on brave-browser dev/beta builds? unsure

Website problems only:

• Does the issue resolve itself when disabling Brave Shields? n/a
• Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

cc @brave/legacy_qa to verify on other platforms
cc @mandar-brave @rebron @NejcZdovc

[btlechowski]

Nice find @LaurenWags !

Reproduced on Windows 7

Brave	0.60.44 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision	fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS	Windows 7

[mandar-brave]

Moving priority to P1 considering it will cause a lot of negative community feedback

[rebron]

@NejcZdovc did this get fix with the last refactor that landed (or is landing) in 61.x?

[kjozwiak]

Labelled this as release/blocking as we should really get this into 0.61.x. @jsecretan would love to get your thoughts on this one and how severe you think the issue is. If @NejcZdovc mentions that the publisher refactor that's in 0.61.x fixes this, then it's not a problem. However if the refactor doesn't handle this issue, we'll need to come up with a timeline.

This might end up being bad in terms of PR when some folks notice their tips went to the wrong publisher.

Edited: Removed release/blocking until we get more info from @NejcZdovc & @jsecretan.

[NejcZdovc]

I just tried on the v0.61.37 and I can still reproduce it. I tried it on the latest master and I can't reproduce it anymore.

[mandar-brave]

@NejcZdovc do we need to uplift a fix to 0.61x; that is the ask. If we can we should.
cc @kjozwiak

[NejcZdovc]

@mandar-brave not sure what fixed it 😃

[NejcZdovc]

@brave/legacy_qa can you please test this one on the latest nightly (0.63) or dev when we migrate today? Thank you

[LaurenWags]

@NejcZdovc tried on below build and issue still reproduces.

Brave	0.63.4 Chromium: 73.0.3683.67 (Official Build) dev (64-bit)
Revision	a83fd4f3207ae83412d329a9ca1239dd1e068345-refs/branch-heads/3683@{#760}
OS	Mac OS X

[Miyayes]

I think this should be resolved with new panel. Also, there's likely a newer version of this issue as well.