Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shields Panel and Rewards Panel are not translated to Norwegian #3425

Closed
btlechowski opened this issue Feb 20, 2019 · 15 comments · Fixed by brave/brave-core#2593 or brave/brave-core#2709
Closed

Shields Panel and Rewards Panel are not translated to Norwegian #3425

btlechowski opened this issue Feb 20, 2019 · 15 comments · Fixed by brave/brave-core#2593 or brave/brave-core#2709
Assignees
@mkarolin
Labels
feature/rewards feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. l10n priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.68.x - Release

Comments

@btlechowski
Copy link

btlechowski commented Feb 20, 2019 •
edited
Loading

Follow up from: #3064

Steps to Reproduce

  1. Change Brave language to Norwegian
  2. Open Brave Shields

Actual result:

Shields panel is not translated
image
Rewards Panel is not translated:
image

Expected result:

Shields panel is translated
Rewards Panel is translated:

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.60.44 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Windows 7

Not reproducible for: Arabic, Bulgarian, Chinese(Traditional), Croatian, Czech, Danish, Dutch, Finish, French, German, Greek, Hebrew, Hungarian, Italian, Japanese, Korean, Lithuanian, Polish, Portuguese, Russian, Slovak, Slovenian, Spanish, Turkish, Vietnamese

cc @brave/legacy_qa @bbondy @tomlowenthal
@btlechowski btlechowski added feature/shields The overall Shields feature in Brave. l10n QA/Yes QA/Test-Plan-Specified feature/shields/panel Front-end design and functionality of the Shields panel. labels Feb 20, 2019
@btlechowski btlechowski mentioned this issue Feb 20, 2019
Closed
@btlechowski btlechowski changed the title Shields panel is not translated to Norwegian Shields Panel and Rewards Panel are not translated to Norwegian Feb 20, 2019
@btlechowski btlechowski mentioned this issue Feb 20, 2019
Closed
@bbondy
Copy link
Member

bbondy commented Feb 20, 2019

components/brave_rewards/resources/extension/BUILD.gn: locale = string_replace(locale, "nb", "no")

Possibly related ^

@LaurenWags
Copy link
Member

Reproduced on macOS

Brave 0.60.44 Chromium: 72.0.3626.109 (Offisiell delversjon) (64-bit)
Versjon fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Mac OS X

@kjozwiak
Copy link
Member

Same results on Mint 19.1 x64 VM using the following build:

Brave 0.60.45 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Mac OS X

Example of the issue occurring on Mint 19.1 x64:

screen shot 2019-02-21 at 10 21 08 pm

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 26, 2019
@cezaraugusto
Copy link
Contributor

still an issue on 0.67.44

@cezaraugusto cezaraugusto mentioned this issue Jun 4, 2019
Merged
@NejcZdovc NejcZdovc added this to the 0.68.x - Nightly milestone Jun 11, 2019
This was referenced Jun 11, 2019
Merged
Merged
Merged
@kjozwiak kjozwiak mentioned this issue Jun 13, 2019
Closed
74 tasks
@kjozwiak
Copy link
Member

Screen Shot 2019-06-14 at 10 39 40 AM

Screen Shot 2019-06-14 at 10 42 02 AM

@bsclifton it doesn't look like the translations made it into the RC builds. Are we sure this landed and has all the correct translations on the release channel? However, #4880 has definitely been fixed.

@btlechowski
Copy link
Author

@bsclifton The translations didn't make it as @kjozwiak noted.

@kjozwiak
Copy link
Member

This seems to be working on all the other channels other than 0.65.x, results:

  • 0.68.50 Chromium: 75.0.3770.87- PASSED
  • 0.67.83 Chromium: 75.0.3770.87 - PASSED
  • 0.66.90 Chromium: 75.0.3770.87 - PASSED
  • 0.65.120 Chromium: 75.0.3770.90 - FAILED

I also checked that each channel looks the same under brave://settings/languages and is picking the same list of languages when the system language is set to the following:

Screen Shot 2019-06-14 at 2 30 22 PM

Seems like the only difference is that 0.65.120 is on 75.0.3770.90 and the remaining channels are currently still on 75.0.3770.87. But I'm not 100% sure if that could be the cause for the above.

@srirambv
Copy link
Contributor

srirambv commented Jun 14, 2019 •
edited by kjozwiak
Loading

Here's the result on Linux/Ubutnu 19.04:

  • Release: Versjon 0.65.120 Chromium: 75.0.3770.90 (Offisiell delversjon) (64-bit) - FAIL
  • Beta: Versjon 0.66.90 Chromium: 75.0.3770.87 (Offisiell delversjon) beta (64-bit) - PASS
  • Dev: Versjon 0.67.83 Chromium: 75.0.3770.87 (Offisiell delversjon) dev (64-bit) - PASS
  • Nightly: Versjon 0.68.48 Chromium: 75.0.3770.87 (Offisiell delversjon) nightly (64-bit) - PASS

@mkarolin mkarolin reopened this Jun 14, 2019
@mkarolin mkarolin self-assigned this Jun 14, 2019
mkarolin added a commit to brave/brave-core that referenced this issue Jun 15, 2019
@mkarolin
Fixes Norwegian localization for shields and rewards.
9317b72 
Fixes brave/brave-browser#3425

- Renames Norwegian resources locale from 'nb' back to 'no', so that
  Transifex produces translations for them. When copying these resources
  rename them to 'nb'.
@mkarolin mkarolin mentioned this issue Jun 15, 2019
Merged
32 tasks
This was referenced Jun 16, 2019
Merged
Merged
@bsclifton
Copy link
Member

bsclifton commented Jun 17, 2019 •
edited
Loading

As noted, originally only the code was updated - no new translations were pulled down. That is something we typically do as part of the Chromium upgrade or ad-hoc when we get better translations for our own content

@bsclifton
Copy link
Member

And awesome - see the other change that @mkarolin made 😄 Thanks for taking care of that!

This was referenced Aug 2, 2019
Closed
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Aug 5, 2019 •
edited by btlechowski
Loading

Verified passed with

Brave 0.68.118 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X

Verification passed on

Brave 0.68.118 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Windows 7 Service Pack 1 (Build 7601.24494)

Still reproducible on Windows, per our process logged: #5546

Verification passed on

Brave 0.68.118 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Ubuntu 18.04 LTS

image
image

@btlechowski btlechowski mentioned this issue Aug 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
feature/rewards feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. l10n priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.68.x - Release
10 participants
@bbondy @kjozwiak @cezaraugusto @bsclifton @rebron @NejcZdovc @srirambv @LaurenWags @btlechowski @mkarolin