Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add funds and Rewards settings are not translated in Rewards Panel #3426

Closed
btlechowski opened this issue Feb 20, 2019 · 4 comments · Fixed by brave/brave-core#1739
Closed

Comments

@btlechowski
Copy link

Steps to Reproduce

  1. Change the language to Polish
  2. Enable rewards
  3. Open a site
  4. Open Rewards Panel

Actual result:

Add funds and Rewards settings are not translated
image

Also reproduced on: Arabic, Bulgarian, Chinese(Traditional), Croatian, Czech, Danish, Dutch, Finish, French, German, Greek, Hebrew, Hungarian, Italian, Japanese, Korean, Lithuanian, Polish, Portuguese, Russian, Slovak, Slovenian, Spanish, Turkish, Vietnamese

Rewards Panel is not translated at all to Norwegian, logged #3425

Expected result:

Add funds and Rewards settings are translated

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.60.44 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Windows 7

cc @brave/legacy_qa @NejcZdovc @bbondy

@btlechowski
Copy link
Author

The issue has not been fixed.

Tested on

Brave 0.63.4 Chromium: 73.0.3683.67 (Official Build) dev (64-bit)
Revision a83fd4f3207ae83412d329a9ca1239dd1e068345-refs/branch-heads/3683@{#760}
OS Windows 7 Service Pack 1 Build 7601.24312

image

@NejcZdovc
Copy link
Contributor

@btlechowski we added translation strings, but not sure if strings were actually translated yet

@NejcZdovc
Copy link
Contributor

cc @bbondy

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 15, 2019

Verification passed on

Brave 0.63.40 Chromium: 74.0.3729.61 (Oficjalna wersja) beta (64-bitowa)
Wersja 5df2c8936783bd7575987e45d72a92fcf528496b-refs/branch-heads/3729@{#645}

Verification passed on

Brave 0.63.42 Chromium: 74.0.3729.75 (Official Build) beta(64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Ubuntu 18.04 LTS

image

Verified passed with

Brave 0.63.44 Chromium: 74.0.3729.75 (Official Build) beta(64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment