Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--rewards=staging=false command-line arg and official builds should use production Ads Serve #3498

Closed
tmancey opened this issue Feb 26, 2019 · 1 comment · Fixed by brave/brave-core#1781

Comments

@tmancey
Copy link
Contributor

tmancey commented Feb 26, 2019

--rewards=staging=false command-line arg and official builds should use production Ads Serve

Steps to Reproduce

  1. Launch browser with --rewards=staging=false or an official build

Actual result:

https://ads-server.bravesoftware.com is used for all communications with the Ads Serve for production

Expected result:

https://ads-server.brave.com should be used for all communications with the Ads Serve for production

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

0.63.x

Reproducible on current release:

No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional Information

Ads Serve URL can be seen in the console log

@tmancey tmancey added this to the 0.63.x - Nightly milestone Feb 26, 2019
@tmancey tmancey self-assigned this Feb 26, 2019
@tmancey tmancey changed the title --rewards=staging=false command-line arg and official builds should use production Ads Serve --rewards=staging=false command-line arg and official builds should use production Ads Serve Feb 26, 2019
tmancey added a commit to brave/brave-core that referenced this issue Feb 26, 2019
@srirambv
Copy link
Contributor

srirambv commented Apr 4, 2019

Verification passed on

Brave 0.63.31 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux

Verification passed on

Brave 0.63.40 Chromium: 74.0.3729.61 (Official Build) beta (64-bit)
Revision 5df2c8936783bd7575987e45d72a92fcf528496b-refs/branch-heads/3729@{#645}
OS Windows 10 OS Build 17134.523

Verified passed with

Brave 0.63.44 Chromium: 74.0.3729.75 (Official Build) beta(64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment