Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a-c table stays corrupted after brave update #3510

Closed
btlechowski opened this issue Feb 27, 2019 · 5 comments · Fixed by brave/brave-core#1803
Closed

a-c table stays corrupted after brave update #3510

btlechowski opened this issue Feb 27, 2019 · 5 comments · Fixed by brave/brave-core#1803

Comments

@btlechowski
Copy link

btlechowski commented Feb 27, 2019

Follow up from #3341
Important: a-c table will not fix itself, even if user visits other sites

Steps to Reproduce

  1. Clean Install 0.60.28
  2. Enable rewards
  3. Open interia.pl and add it to a-c table
  4. Open foxnews.com and add it to a-c table
  5. Exclude foxnews.com for a-c table in brave://rewards
  6. Open cnn.com and add it to a-c table
  7. Open foxnews.com and try to add it to a-c table
  8. check a-c table - it is corrupted(sum of attention values is not 100%)
  9. Update to 0.61.36
  10. Open foxnews.com and try to add it to a-c table
  11. Open youtube.com and add it to a-c table
  12. check a-c table

Actual result:

a-c table stays corrupted after brave update
All attention values don't add up to 100%
image

Note: Restoring the excluded sites will fix the a-c table

Expected result:

All attention values add up to 100%

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.61.38 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

cc @brave/legacy_qa @NejcZdovc @rebron

@NejcZdovc
Copy link
Contributor

I am not able to corrupt profile with Version 0.60.45 Chromium: 72.0.3626.109 (Official Build) (64-bit)

@btlechowski
Copy link
Author

I am also not able to corrupt the profile on 0.60.45.

Brave 0.60.45 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Windows

@NejcZdovc NejcZdovc self-assigned this Feb 28, 2019
@NejcZdovc NejcZdovc added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 28, 2019
@NejcZdovc
Copy link
Contributor

this is not only problem for upgrade scenario. This can be easily reproduced.

  • add site to ac table
  • remove it from ac table
  • include it back in the panel
  • ac table will still exclude it, where % will be off

@GeetaSarvadnya
Copy link

The issue is Reproducible on Upgraded profile. I have upgraded Brave beta 0.60.28 by 0.61.40

@NejcZdovc NejcZdovc added this to the 0.63.x - Nightly milestone Mar 4, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Mar 5, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Mar 7, 2019
@btlechowski
Copy link
Author

btlechowski commented Mar 20, 2019

Verification passed on

Brave 0.63.14 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523

Used STR from the description.
Used test plan from brave/brave-core#1803

Verification passed on

Brave 0.63.14 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux

Verified passed with

Brave 0.63.21 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants