Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary gets for publisher data #3525

Closed
NejcZdovc opened this issue Feb 28, 2019 · 1 comment · Fixed by brave/brave-core#1822
Closed

Remove unnecessary gets for publisher data #3525

NejcZdovc opened this issue Feb 28, 2019 · 1 comment · Fixed by brave/brave-core#1822
Assignees
@NejcZdovc
Labels
dev-concern feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.63.x - Release ...

Comments

@NejcZdovc
Copy link
Contributor

Now that we update % based on normalize observer (done here brave/brave-core#1780), we don't need to get publisher data anymore if panel is opened for the same publisher. We only need to get data if publisher is different
@NejcZdovc NejcZdovc self-assigned this Feb 28, 2019
@NejcZdovc NejcZdovc added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Mar 1, 2019
@NejcZdovc NejcZdovc mentioned this issue Mar 2, 2019
Merged
19 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue Mar 2, 2019
@NejcZdovc
Removes unnecessary getters for the same publisher
2922917 
Resolves brave/brave-browser#3525
@NejcZdovc NejcZdovc added this to the 0.63.x - Nightly milestone Mar 4, 2019
@btlechowski
Copy link

btlechowski commented Mar 14, 2019 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.63.4 Chromium: 73.0.3683.67 (Official Build) dev (64-bit)
Revision a83fd4f3207ae83412d329a9ca1239dd1e068345-refs/branch-heads/3683@{#760}
OS Windows 7 Service Pack 1 Build 7601.24312

Used test plan from brave/brave-core#1822

Verification passed on

Brave 0.63.12 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux

Verified passed with

Brave 0.63.14 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

@LaurenWags LaurenWags mentioned this issue Mar 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
dev-concern feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.63.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Removes unnecessary getters for the same publisher brave/brave-core
5 participants
@rebron @NejcZdovc @LaurenWags @btlechowski @GeetaSarvadnya