Download toolbar not getting notified of color theme change

[petemill]

Description

Test plan / Steps to Reproduce

1. Set Dark Theme in Settings
2. Restart Brave
3. Right-click any link, choose 'Save link as...' and press OK in file dialog.
4. Set Light Theme in Settings

Actual result:

Expected result:

Downloads toolbar uses light theme

Reproduces how often:

100%

Brave version (brave://version info)

Brave	0.63.4 Chromium: 73.0.3683.67 (Official Build) dev (64-bit)
Revision	a83fd4f3207ae83412d329a9ca1239dd1e068345-refs/branch-heads/3683@{#760}

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds? Yes, beta (0.62.x) and dev (0.63.x)

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
• Is the issue reproducible on the latest version of Chrome?

Additional Information

[simonhong]

Fixed by brave/brave-core#1805

[LaurenWags]

Verified passed with

Brave	0.62.31 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision	909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS	Mac OS X

• Verified STR from description. @kjozwiak could you check the test plan from OS(MacOS/Windows) theme controls brave theme brave-core#1805 on Mojave?

[srirambv]

Issue not fixed on Linux. Logged a follow up issue #3793

[btlechowski]

Verification passed on

Brave	0.62.32 Chromium: 73.0.3683.75 (Official Build) beta (64-bit)
Revision	909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS	Windows 10 OS Build 17134.523

Brave	0.63.14 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision	909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS	Windows 10 OS Build 17134.523

Used STR from the description

Verification PASSED on macOS 10.14.3 x64 using the following build:

Brave	0.63.14 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision	909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS	Mac OS X

• went through the test case outlined under OS(MacOS/Windows) theme controls brave theme brave-core#1805
• went through the test case outlined under Download toolbar not getting notified of color theme change #3708 (comment)

[kjozwiak]

• Verified STR from description. @kjozwiak could you check the test plan from OS(MacOS/Windows) theme controls brave theme brave-core#1805 on Mojave?

Looks good on macOS 10.14.3 x64 running Mojave 👍

[srirambv]

Adding Windows/macOS labels as its not fixed on Linux and follow up issue #3793 logged specifically for Linux