Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bookmarklet should be able to execute even when you block all scripts #3765

Open
dangh opened this issue Mar 18, 2019 · 0 comments
Open

Bookmarklet should be able to execute even when you block all scripts #3765

dangh opened this issue Mar 18, 2019 · 0 comments
Labels
bug feature/shields/!scripts Blocking JavaScript with Shields OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. webcompat/shields Shields is breaking a website.

Comments

@dangh
Copy link

dangh commented Mar 18, 2019 •
edited
Loading

Description

Bookmarklet should be able to execute even when you block all scripts.

Steps to Reproduce

  1. Add this bookmarklet to your bookmark javascript:alert('hello')
  2. Open any website
  3. Click on that bookmark

Actual result:

Nothing happen

Expected result:

Alert "hello"

Reproduces how often:

Very easy to reproduce.

Brave version (brave://version info)

Brave 0.61.51 Chromium: 73.0.3683.75 (Official Build) (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 7 Service Pack 1 Build 7601.24385

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes it does. Checked on
Brave 0.63.4 Chromium: 73.0.3683.67 (Official Build) dev (64-bit)
Revision a83fd4f3207ae83412d329a9ca1239dd1e068345-refs/branch-heads/3683@{#760}
OS Mac OS X

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? Yes
  • Is the issue reproducible on the latest version of Chrome? No

Additional Information
@bsclifton bsclifton added feature/shields/!scripts Blocking JavaScript with Shields bug webcompat/shields Shields is breaking a website. labels Mar 18, 2019
@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug feature/shields/!scripts Blocking JavaScript with Shields OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. webcompat/shields Shields is breaking a website.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dangh @bsclifton @rebron