Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download toolbar theme mismatch - not getting notified of color theme change Follow up to #3708 #3793

Closed
srirambv opened this issue Mar 19, 2019 · 4 comments · Fixed by brave/brave-core#2905
Assignees
Labels
bug design A design change, especially one which needs input from the design team feature/download OS/Linux priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

srirambv commented Mar 19, 2019

Description

Download toolbar not getting notified of color theme change follow up to #3708

Test plan / Steps to Reproduce

  1. Download a file
  2. Change brave colour to light/dark, toolbar doesn't update
  3. Change to classic, dark/light colour shows correct toolbar
  4. Change to GTK+, same white bar for both dark/light colour

Actual result:

toolbar

Expected result:

Should not change GTK+ to Classic for correct theme to be used. Should be dependent on Brave colours

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.62.32 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Same on all channels

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @petemill

@srirambv srirambv added bug design A design change, especially one which needs input from the design team feature/download OS/Linux QA/Yes QA/Test-Plan-Specified labels Mar 19, 2019
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Mar 22, 2019
@eljuno
Copy link

eljuno commented Apr 30, 2019

+1 from Community https://community.brave.com/t/browser-colors-cant-read-filenames-of-downloaded-files-when-in-dark-mode/57363?u=eljuno

Reproduced on Windows 10 with Brave 0.63.x.

My Windows color scheme is dark, but I set my browser to light.

@simonhong
Copy link
Member

simonhong commented Apr 30, 2019

Duplicated this with #965 - GTK theme issue on Linux.

@simonhong
Copy link
Member

Reproduced on Windows 10 with Brave 0.63.x.

@eljuno We have #4272 for Windows

@btlechowski
Copy link

Verification passed on

Brave 0.69.117 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Ubuntu 18.04 LTS

Verified STR from the description.

image
image
image
image

@rebron rebron changed the title Download toolbar not getting notified of color theme change Follow up to #3708 Download toolbar theme mismatch - not getting notified of color theme change Follow up to #3708 Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug design A design change, especially one which needs input from the design team feature/download OS/Linux priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants