Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Beta label for Sync #3847

Closed
rebron opened this issue Mar 22, 2019 · 2 comments · Fixed by brave/brave-core#2068
Closed

remove Beta label for Sync #3847

rebron opened this issue Mar 22, 2019 · 2 comments · Fixed by brave/brave-core#2068
Labels
feature/sync priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.63.x - Release ...

Comments

@rebron
Copy link
Collaborator

rebron commented Mar 22, 2019 •
edited by bsclifton
Loading

Test plan

See brave/brave-core#2068

Description

Remove (Beta) label for Sync on initial setup screen and main page.

Current
Screen Shot 2019-03-21 at 8 20 37 PM

Screen Shot 2019-03-21 at 8 28 32 PM

Expected
see #3079
@rebron
Copy link
Collaborator Author

rebron commented Mar 22, 2019

cc: @anthonypkeane

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 22, 2019
bsclifton added a commit to brave/brave-core that referenced this issue Mar 25, 2019
@bsclifton
Remove "Beta" label from sync
7ce37d7 
Fixes brave/brave-browser#3847
@bsclifton bsclifton mentioned this issue Mar 25, 2019
Merged
19 tasks
@bsclifton bsclifton added this to the 0.64.x - Nightly milestone Mar 25, 2019
bsclifton added a commit to brave/brave-core that referenced this issue Apr 16, 2019
@bsclifton
Remove "Beta" label from sync
2627011 
Fixes brave/brave-browser#3847
@bsclifton bsclifton mentioned this issue Apr 16, 2019
Merged
19 tasks
@bsclifton bsclifton modified the milestones: 0.64.x - Dev, 0.63.x - Beta Apr 16, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Apr 19, 2019 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave 0.63.45 Chromium: 74.0.3729.75 (Official Build) beta(64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Mac OS X

Verification passed on

Brave 0.63.45 Chromium: 74.0.3729.75 (Official Build) beta(64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Linux

image
image

Verification passed on

Brave 0.63.46 Chromium: 74.0.3729.91 (Official Build) (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Windows 10 OS Build 17134.523

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/sync priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.63.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Remove "Beta" label from sync brave/brave-core
5 participants
@bsclifton @rebron @srirambv @LaurenWags @GeetaSarvadnya