Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for music.youtube.com #4148

Closed
mileswatson opened this issue Apr 17, 2019 · 0 comments
Closed

Add support for music.youtube.com #4148

mileswatson opened this issue Apr 17, 2019 · 0 comments
Assignees
Labels
feature/rewards greaselion priority/P4 Planned work. We expect to get to it "soon".

Comments

@mileswatson
Copy link

Description

Brave rewards tab only recognises the base URL "music.youtube.com" as "youtube.com". Any other path produces the "No activities yet" page on the Brave Rewards window. Furthermore, "https://youtube.com/results?q=example" also suffers from this issue.

Steps to Reproduce

  1. Visit "https://music.youtube.com/hotlist", "https://music.youtube.com/library", or "https://music.youtube.com/search?q=example" URLs. This also occurs on "https://youtube.com/search?q=example".
  2. Click on the brave rewards icon in the top right.

Actual result:

The Brave Rewards window will display the "No activities yet..." page.

Expected result:

It should recognise "youtube.com" as the domain, e.g. "youtube.com (?) Not yet verified" (like it is on "https://youtube.com")

Reproduces how often:

Easily Reproduced

Brave version (brave://version info)

Brave: 0.64.56 Chromium: 74.0.3729.75 (Official Build) dev (64-bit)
Revision: fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS: Windows 10 OS Build 17134.706

Version/Channel Information:

Tested on dev and nightly, possibly occurs on other channels.

@mileswatson mileswatson changed the title Issues with recognising "music.youtube.com" as Youtube in Brave Rewards. Issues with recognising "music.youtube.com" as "youtube.com" in Brave Rewards. Apr 17, 2019
@NejcZdovc NejcZdovc added the priority/P4 Planned work. We expect to get to it "soon". label May 27, 2019
@NejcZdovc NejcZdovc changed the title Issues with recognising "music.youtube.com" as "youtube.com" in Brave Rewards. Add support for music.youtube.com Apr 10, 2020
@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards greaselion priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Development

No branches or pull requests

6 participants