Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confusing content settings names #42

Closed
bbondy opened this issue Dec 28, 2017 · 0 comments
Closed

Fix confusing content settings names #42

bbondy opened this issue Dec 28, 2017 · 0 comments

Comments

@bbondy
Copy link
Member

bbondy commented Dec 28, 2017

We currently use 'allow' for content setting of ad-block which is confusing because you're allowing the ad-block of ads.

Instead change to content settings name of 'ads' and allow or block them.

Also it's an issue if you toggle on and off in sequence for top level shields, it clears the saved previous values of the sub-shield settings. This needs to be stored separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant